Implementing a custom Writer / Reader about riegeli HOT 5 CLOSED

The error indicates dereferencing a null pointer and accessing its field at offset 0xc0.

Depending on how RecordWriter template is instantiated and which constructor of RecordWriter is called, you might need move constructor and move assignment. Compiler-generated ones might be correct or not, depending on member variables of your class.

You likely need to also override Done (and call BufferedWriter::Done() in it), assuming that the stream needs to be closed somehow and that closing it might fail.

FdWriter might be hard to follow because it derives from FdWriterBase (for functionality common between FdWriter template instantiations) and FdWriterCommon (for functionality common between FdWriterBase and FdStreamWriterBase). If you do not need a configurable policy regarding owning the underlying Amazon S3 stream, your class does not have to be a template, so it would look more like FdWriter + FdWriterBase + FdWriterCommon flattened. Other aspects of FdWriter (like dest_fd, dest, Reset) are provided for completeness or efficiency and do not need to be emulated.

If you can show the code, I could try to find the error.

from riegeli.

Thank you for your quick response!
My code is here: https://gist.github.com/CodeArno/d922d50de4bd3624b8750fc2b717fc9d
Other than the line "Initialize for..." from initialize() nothing gets logged, so it doesn't seem like any of my other methods ever get called.

from riegeli.

The appropriate base class constructor must be called:

RiegeliS3Writer::RiegeliS3Writer(
    Aws::S3::S3Client* s3_client, const std::string& bucket_name, const std::string& key_path)
    : riegeli::BufferedWriter(riegeli::kDefaultBufferSize),
      s3_client_(s3_client), bucket_name_(bucket_name), key_path_(key_path) {
  initialize();
}

The default constructor constructs a dummy closed object.

I will think what to do to make it more clear or to let it fail in a more obvious way.

from riegeli.

That did it - everything works now. Thank you so much!

from riegeli.

6d4d59c should make this a tiny bit more helpful.

from riegeli.