Git Product home page Git Product logo

Comments (2)

mancini0 avatar mancini0 commented on April 28, 2024

I created PR #67 to address this issue.
A possible corner case is if a user sets multiple unique legal fields of a oneof, i.e, given

 oneof some_val{
string val_a =1;
int64 val_b=2;
}

and

builder.setValA("foo").setValB(123)

, the last oneof value setter called on the builder is the one that survives, according to the protobuf language specification. So ordering of the input map is consequential and should be preserved. The other case where a user sets the same oneof filed multiple times, i.e

builder.setValA("foo").setValA("bar")

already throws a duplicate key exception by the existing code.

from rejoiner.

mancini0 avatar mancini0 commented on April 28, 2024

This works as expected - my error must've been syntax related.

from rejoiner.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.