std::vector "Out of Bounds" memory violation in ResampleAndReturnResults (Undefined behavior) about reaper HOT 1 OPEN

I have found this same memory corruption. A few notes from what I found:

Our team believes RoundUp() to be misleadingly named, it is doing traditional rounding where [X + .5, X + 1.5) will round to X. It's more of just...Round.

The point still remains the same. I can end up with a situation where, for example, the float being rounded for size is (97.499999999) and the float being rounded for index is (96.5), so the vector ends up overrunning by one.

I duplicated this from the command line. I unfortunately can't share the wav, but this command:

build/reaper -i <some_unlucky_wav_file> -f freq.f0 -p pitchmark.pm -a -e 0.01

will cause a memory corruption (I hunted down the source using ASAN and it identified this invalid write as described).

It doesn't happen with every wav file, but once you find one where it happens it is consistent.

from reaper.