generatedFileDir does not follow Gradle Java Plugin conventions (nor can you) about protobuf-gradle-plugin HOT 8 CLOSED

This is a duplicate of #13. I think it makes sense to let java_out to be ${project.projectDir}/src/${sourceSet.name}/java.

Then javanano_out to be ${project.projectDir}/src/${sourceSet.name}/javanano, and grpc_out to be ${project.projectDir}/src/${sourceSet.name}/grpc?

from protobuf-gradle-plugin.

This actually looks like something the user should be able to configure to be something else. We can by default put it some place, but it should be able to be overridden.

from protobuf-gradle-plugin.

It not only looks bad, but also causes problem in setting up directory structure when sourceSet.name is artificially added to it. Gradle default practice is to have a java directory inside its source set, but its impossible use that structure currently.

from protobuf-gradle-plugin.

I am working on a new version that will change the default output path to "$buildDir/generated/source/proto/$sourceSet/$name", where $name is java, python etc. This will align with Gradle default practice. I will possibly make the prefix, i.e., "$buildDir/generated/source/proto/" configurable through a property named generatedBaseDir if desired.

from protobuf-gradle-plugin.

This actually looks like something the user should be able to configure to be something else. We can by default put it some place, but it should be able to be overridden.

@ejona86 Allow overriding the outputDir on the codegen plugin or task granularity is hard to implement correctly (see #13 (comment)). So far, people have been just wanting that generated files of different codegen plugins can be in separate directories, which doesn't require fine-grained customization.

from protobuf-gradle-plugin.

@zhangkun83, how will we commit code generated code? https://github.com/grpc/grpc-java/blob/master/build.gradle#L60

from protobuf-gradle-plugin.

@ejona86 this is a use case for customizing the global base dir, which we can still support.

from protobuf-gradle-plugin.

Let's move discussions to #13

from protobuf-gradle-plugin.