Comments (2)
Thank you for the report. I have mixed feelings about such a change, as well as the discoverability of such a feature. If the user doesn't put the right module name ahead of time in exposed-modules
, then proto-lens
won't generate code for that .proto
file, and the user will need to know ahead of time to use the magic "Dot" replacement in the module name.
At the least, though, we should change the proto generation code to detect if any of the proto files have a .
in their path and give a better error message.
In your project, would it have worked to pass the full path to .protodir
as the root dir (for example: main = defaultMainGeneratingProtos ".protodir"
) so that .protodir/myfilename.proto
would just become Proto.Myfilename
? If so, that would be my preference for the level that we support. But if not, let us know and we can consider another approach.
from proto-lens.
Another possibility would be to allow overriding the generated module name, similar to: https://github.com/google/protobuf/blob/master/src/google/protobuf/descriptor.proto#L324
which might solve a more general class of such problems. Though that would probably require implementing #27 to be able to use Haskell-specific custom options, similar to ScalaPbOptions
from proto-lens.
Related Issues (20)
- Too strict bounds on profunctors on hackage HOT 2
- Release for Stackage LTS-18.0 HOT 5
- Support GHC 9
- `readMessage` from `TextFormat` chokes on unicode in strings
- Re-add blackgnezdo HOT 2
- Increment upper bounds for some dependencies HOT 2
- New Hackage release HOT 3
- Support lazy construction for byte fields HOT 2
- Not compatible with mtl-2.3 and transformers-0.6 HOT 3
- google/protobuf/struct.proto not included in protobuf types HOT 2
- Show instance not working for first/default enum values
- Show instance not working for first/default enum values
- Support GHC 9.4 HOT 10
- Compilation hangs after some `default-extensions` added. HOT 1
- Replace deprecated `set-output` command with environment file
- Support deepseq-1.5 and bytestring-0.12
- Bump upper bounds for base, containers, ghc-prim, primitive
- Any way to generate protobuf schema from haskell types? HOT 2
- Please issue new Hackage release of proto-lens-protobuf-types HOT 2
- Support "Protobuf Editions"
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from proto-lens.