Git Product home page Git Product logo

Comments (2)

judah avatar judah commented on September 1, 2024

Thank you for the report. I have mixed feelings about such a change, as well as the discoverability of such a feature. If the user doesn't put the right module name ahead of time in exposed-modules, then proto-lens won't generate code for that .proto file, and the user will need to know ahead of time to use the magic "Dot" replacement in the module name.

At the least, though, we should change the proto generation code to detect if any of the proto files have a . in their path and give a better error message.

In your project, would it have worked to pass the full path to .protodir as the root dir (for example: main = defaultMainGeneratingProtos ".protodir") so that .protodir/myfilename.proto would just become Proto.Myfilename? If so, that would be my preference for the level that we support. But if not, let us know and we can consider another approach.

from proto-lens.

judah avatar judah commented on September 1, 2024

Another possibility would be to allow overriding the generated module name, similar to: https://github.com/google/protobuf/blob/master/src/google/protobuf/descriptor.proto#L324
which might solve a more general class of such problems. Though that would probably require implementing #27 to be able to use Haskell-specific custom options, similar to ScalaPbOptions

from proto-lens.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.