Comments (5)
Ah, sorry, this was a really poor description 😀 The lack of trailing newlines is IMO a bug (see https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline for the philosophical reasons, but the pragmatic ones are that tools expect it and complain in various ways without it). Concretely: There should be a \n
at the end of every generated file.
from proto-lens.
Can you be more specific about this request? It looks like currently the generated files don't have trailing newlines. Can you explain what difference this formatting change would make?
from proto-lens.
Sounds reasonable. Would you like to send a patch? This is where we create the file contents:
https://github.com/google/proto-lens/blob/master/proto-lens-protoc/src/protoc-gen-haskell.hs#L84
Out of curiosity, which tool complained about the missing newline? Was it a text editor or something more automated?
from proto-lens.
git diff
shows \ No newline at end of file
and on github there's a red octicon-no-newline (https://octicons.github.com/icon/no-newline/) in the diffs, is how I saw this one.
Will whip up a patch, thanks!
from proto-lens.
Sorry, I haven't had time to work on this and won't likely for the forseable future.
from proto-lens.
Related Issues (20)
- Installing protoc doc
- Text format parser doesn't accept all valid boolean values
- Too strict bounds on profunctors on hackage HOT 2
- Release for Stackage LTS-18.0 HOT 5
- Support GHC 9
- `readMessage` from `TextFormat` chokes on unicode in strings
- Re-add blackgnezdo HOT 2
- Increment upper bounds for some dependencies HOT 2
- New Hackage release HOT 3
- Support lazy construction for byte fields HOT 2
- Not compatible with mtl-2.3 and transformers-0.6 HOT 3
- google/protobuf/struct.proto not included in protobuf types HOT 2
- Show instance not working for first/default enum values
- Show instance not working for first/default enum values
- Support GHC 9.4 HOT 10
- Compilation hangs after some `default-extensions` added. HOT 1
- Replace deprecated `set-output` command with environment file
- Support deepseq-1.5 and bytestring-0.12
- Bump upper bounds for base, containers, ghc-prim, primitive
- Any way to generate protobuf schema from haskell types? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from proto-lens.