Git Product home page Git Product logo

Comments (4)

shoumikhin avatar shoumikhin commented on April 28, 2024

Hi Fernando,

To make any Swift func visible for ObjC you need an @objc annotation.
Your idea of a duplicate method that you can then expose for ObjC is the right one.
Here's the pattern to follow in your Swift pod:

@objc(MyObjCClass)
public class MyClass: NSObject {
  public func fooBar() -> Promise<String> {
    // ...
    return Promise("hello world")
  }
  
  @objc(objc_fooBar)
  public func fooBar() -> Promise<String>.ObjCPromise<NSString> {
    return fooBar().asObjCPromise()
  }
}

Then use it from an ObjC target:

#import "MySwiftPod-Swift.h"

FBLPromise<NSString *> *fooBarPromise = [[MyObjCClass new] objc_fooBar];

If you have a lot of such methods in your class, you may consider moving them into a separate extension just to make the code look cleaner, like so:

public class MyClass: NSObject {
  public func fooBar() -> Promise<String> {
    // ...
    return Promise("hello world")
  }
  // ...
}

// Objective-C interface.
public extension MyClass {
  @objc(objc_fooBar)
  public func fooBar() -> Promise<String>.ObjCPromise<NSString> {
    return fooBar().asObjCPromise()
  }
  // ...
}

Let us know if you have any further questions.
Thanks.

from promises.

matcoope avatar matcoope commented on April 28, 2024

I'm using this approach, but can't see how to handle errors in objective c.

I use the following in swift:

Test.client.createUser(firstName: "firstname", lastName: "lastname").then { _ -> Void in
   assertionFailure("duplicate user created")
}.catch { error in
   assert(error is RequestError, "RequestError returned")
   let requestError = error as? RequestError
}

RequestError is a swift class visible in objective c

@objc(AGMRequestError)
public class RequestError

and in objective c

    [client createUserWithFirstName:@"firstname" withLastName:@"lastname"] .then(^id(AGAccessToken *accessToken) {
        XCTFail("duplicate user")
        return nil;
    })
     .catch(^(NSError *error) {
         AGMRequestError *requestError = (AGMRequestError *)error;
    });

error is of type _SwiftNativeNSError, not AGMRequestError, so I can't access any of its details

from promises.

shoumikhin avatar shoumikhin commented on April 28, 2024

Hi Matt,

Given your RequestError has @objc annotation, I assume it already derives from NSObject? Any chance you derive it from NSError instead? Then you can create instances of RequestError in Swift as follows: RequestError(domain: "your domain", code: 42, userInfo: nil) or with a custom constructor, and cast to AGMRequestError in Objective-C.

By the way, you may also like declaring errors as enums in Swift and conforming to CustomNSError protocol to be able to extract domain, code and userInfo everywhere. Take a look at an example.

Thanks.

from promises.

matcoope avatar matcoope commented on April 28, 2024

Hello,

Thank you for the suggestion. Yes RequestError derived from NSObject, and Error but I've changed it to just derive from NSError and that works - I can then cast to AGMRequestError in Objective-C.

I'll also consider conforming to CustomNSError instead. RequestError currently has a type, code, and description, but I could use userInfo for the type and description.

from promises.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.