Comments (10)
Would you mind to make a small text case demonstrating the issue?
May just edit one of the test files we already have, like Promise+ThenInteroperabilityTests.swift
, or create a custom one.
Happy to play with it and see if we can do better.
from promises.
Interesting, a reduced example doesn't cause the compiler crash. I was thinking it might be getting confused by the re-use of Value
, but in simpler cases it doesn't seem to be the case.
from promises.
Hi Mark,
What if you try something like:
@objc
public func allFoo() -> Promise<[Foo]>.ObjCPromise<NSArray> {
return promiseSwiftArrayOfFoo().asObjCPromise()
}
from promises.
That was actually what I was doing - I simplified it to use the map in case that helped, both crash in my code.
What does seem to work though is explicitly using FBLPromise<NSArray>
as the return type. Compiles fine, haven't tested it yet.
from promises.
Sorry, I think there must be an @objc
qualifier in the example above. Corrected.
Let us know what solutions works for you eventually.
Another idea that may come handy - a way to have both methods in one class and call different one from Swift and Objective-C respectively:
public func allFoo() -> Promise<[Foo]> {
return promiseSwiftArrayOfFoo()
}
@objc
public func objc_allFoo() -> Promise<[Foo]>.ObjCPromise<NSArray> {
return allFoo().asObjCPromise()
}
from promises.
Ok, so a current workaround is:
import Promises
import FBLPromise
@objc
public func allFoo() -> FBLPromise<NSArray>
{
return promiseSwiftArrayOfFoo().asObjCPromise()
}
Despite requiring the extra import, this actually reads a bit cleaner, so I'm ok with it. Of course swiftc
shouldn't crash, and I'll keep trying to make a reduced sample that does trigger the crash.
from promises.
Interesting... So you mean if you replace Promise<[Foo]>.ObjCPromise<NSArray>
return type with FBLPromise<NSArray>
, it does fix the crash?
from promises.
Yes.
from promises.
The crash is in the name mangling/compression code when swiftc is generating the ObjC header, so it sort of makes sense. When the type is a plain ObjC type that code doesn't need to run, it can just use the ObjC type directly.
from promises.
Hey Mark, going to close this issue for now. Feel free to reopen if you have any additional details or can provide a simple test case that repros the issue. Thank you!
from promises.
Related Issues (20)
- Contextual type for closure argument list expects 1 argument, which cannot be implicitly ignored
- Objective-C Promises crashes in SwiftUI previews HOT 3
- ios 16 strings convertible to NSError HOT 1
- FBLPromises fails to load building macos flutter app HOT 2
- 'NSInvalidArgumentException', reason: '-[FBLPromise HTTPBody]: unrecognized selector sent to instance HOT 1
- Confused when retry a Promise variable
- type(of: value) is NSError.Type HOT 1
- Bitcode Issue on Xcode 13 when disable it. HOT 1
- Question regarding implementation HOT 3
- Ignore a certain Error and terminate Promise HOT 5
- Please release a new version of promises that includes latest changes for Firebase HOT 4
- Builds including PromisesSwift failing on CI
- Build fails for macOS with Xcode 14.3
- Create releases for new versions HOT 1
- The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 12.0 to 17.0.99.
- Privacy manifest for sensitive APIs HOT 6
- Version 2.4.0 not compiling HOT 15
- iOS build issue with 2.4.0 HOT 5
- PrivacyInfo.xcprivacy is not included in the framework output built by Carthage HOT 1
- FBLPromises.xcframework missing mac_catalyst support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from promises.