Git Product home page Git Product logo

Comments (4)

zontag avatar zontag commented on April 28, 2024 1

Really better, great solution! It solved the problem and keeps the code elegant and simple. Thanks!

from promises.

shoumikhin avatar shoumikhin commented on April 28, 2024

Hi Tiago,

What kind of a Map extension would you like to see? Any examples? Perhaps we already have what you need?

Thanks.

from promises.

zontag avatar zontag commented on April 28, 2024

Hi Tiago,

What kind of a Map extension would you like to see? Any examples? Perhaps we already have what you need?

Thanks.

I'm converting my project from PromiseKit to Promises and in some places where I used PromiseKit extensions like map, mapValues, compactMap and compactMapValues was needed some more imperative code. Maybe I'm missing something but here are a code comparation. Note that I opted for explicit closure typed because compiler was pain on guess it.

return userDBManager
                .getAll(.promise)
                .compactMap(on: bgq) { $0.first }
                .compactMap(on: bgq) { $0.selectedMachines }
                .compactMapValues(on: bgq) { $0 as? MachineMO } // Casting
                .mapValues(on: bgq, toMachine)
                .recover { _ in Guarantee.value([]) }

agains

return userDBManager
                .getAllPromise()
                .then(on: bgq) { $0.first }
                .validate(on: bgq) { $0 != nil }
                .then(on: bgq) { (user: UserMO?) -> NSSet? in
                    user!.selectedMachines
                }
                .validate(on: bgq) { $0 != nil }
                .then(on: bgq) { (set: NSSet?) -> [MachineMO] in
                    set!.compactMap { $0 as? MachineMO }
                }.then(on: bgq) { (entities: [MachineMO]) -> [Machine] in
                    entities.compactMap(toMachine)
                }.recover { _ in [Machine]() }

Same without explicit types:

return userDBManager
                .getAllPromise()
                .then(on: bgq) { $0.first }
                .validate(on: bgq) { $0 != nil }
                .then(on: bgq) { user!.selectedMachines }
                .validate(on: bgq) { $0 != nil }
                .then(on: bgq) { set!.compactMap { $0 as? MachineMO } }
                .then(on: bgq) { entities.compactMap(toMachine) }
                .recover { _ in [Machine]() }

from promises.

shoumikhin avatar shoumikhin commented on April 28, 2024

Many thanks for the example! Wonder if you could leverage nil-coalescing for all of that instead?

return userDBManager.getAllPromise().then(on: bgq) {
  $0?.first?.selectedMachines?.compactMap { $0 as? MachineMO }?.compactMap(toMachine) ?? []
}

from promises.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.