Git Product home page Git Product logo

Comments (6)

shoumikhin avatar shoumikhin commented on September 1, 2024 2

In general case, you'd need some sort of a custom cancellation token at this point, depending on what you plan to accomplish. For network requests specifically, you may find URLSessionTask APIs pretty handy, and use them like:

class Fetcher {
  var task: URLSessionDataTask?

  func fetch(url: URL) -> Promise<(Data?, URLResponse?)> {
    cancel()
    return wrap { (handler: @escaping (Data?, URLResponse?, Error?) -> Void) in
      self.task = URLSession.shared.dataTask(with: url, completionHandler: handler)
      self.task?.resume()
    }
  }

  func cancel() {
    task?.cancel()
  }
}

let fetcher = Fetcher()
fetcher.fetch(url: URL(string: "https://google.com")!).then { _, response in
  print(response)
}.catch { error in
  print(error)
}
DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
  fetcher.cancel()
}

from promises.

shmidt avatar shmidt commented on September 1, 2024 1

@shoumikhin This will only cancel previous request if you make a new one, right?
So there is no way currently to just cancel promise?

from promises.

aaronbrethorst avatar aaronbrethorst commented on September 1, 2024

Thanks for the example. I'd love to see this folded into your docs.

from promises.

shoumikhin avatar shoumikhin commented on September 1, 2024

@shmidt Some examples on how you'd like to cancel the promise are highly appreciated.

Keep in mind, one can always invoke promise.reject(error) anytime to trigger the failure scenario, if needed.

BTW, just noticed the above code can be simplified with wrap like so:

func fetch(url: URL) -> Promise<(Data?, URLResponse?)> {
  cancel()
  return wrap { (handler: @escaping (Data?, URLResponse?, Error?) -> Void) in
    self.task = URLSession.shared.dataTask(with: url, completionHandler: handler)
    self.task?.resume()
  }
}

from promises.

shmidt avatar shmidt commented on September 1, 2024

@shoumikhin Thanks for the fast reply.
In my case, I plan to run asynchronously time consuming NSTask process, which I would like to stop if user decides to close a window, so I was looking for some code similar to the one I found for ReactiveKit:

func getUser() -> Signal<User, ClientError> {
  return Signal { observer in
    let task = getUser(completion: { result in
      switch result {
      case .success(let user):
        observer.next(user)
        observer.completed()
      case .failure(let error):
        observer.failed(error)
    })

    return BlockDisposable {
      task.cancel()
    }
  }
} 

where task.cancel() will be called when signal gets disposed.

from promises.

 avatar commented on September 1, 2024

current code:

    public static func download(token: Cancellation.Token? = nil) -> Promise<Data> {
        return Promise { fulfill, reject in
            // simulate download ..., typically data will come in chunks and will be cached ...  
            DispatchQueue.main.asyncAfter(deadline: .now() + 2, execute: {
                if let token = token, token.isCancellationRequested {
                    return reject(Error.cancel)
                } else {
                    return fulfill(Data())
                }
            })
        }
    }
    let source = Cancellation.Source()
    
    let promise = download(token: source.token)
        .then({ (data) in
            print("data -----> ", data)
        })
        .catch({ (error) in
            print("ERROR -> ", error)
        })
    
    DispatchQueue.main.asyncAfter(deadline: .now() + 1, execute: {
        // simulate user pressed stop downloading ...
        source.cancel()
    })

proposal:

implement something like this: https://github.com/vadymmarkov/When#fail
or maybe reevaluate #31

Other suggestions ?

from promises.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.