Comments (6)
Hi @umbri,
Any usage examples?
from promises.
let progress = Progress(totalUnitCount: 4) // promises count
when([
Promise<String> { fulfill, reject in
DispatchQueue.main.asyncAfter(deadline: .now() + 1, execute: {
print("1")
progress.completedUnitCount += 1
fulfill("1")
})
},
Promise { fulfill, reject in
DispatchQueue.main.asyncAfter(deadline: .now() + 2, execute: {
print("2")
progress.completedUnitCount += 1
fulfill("2")
})
},
Promise { fulfill, reject in
DispatchQueue.main.asyncAfter(deadline: .now() + 3, execute: {
print("3")
progress.completedUnitCount += 1
fulfill("3")
})
},
Promise { fulfill, reject in
DispatchQueue.main.asyncAfter(deadline: .now() + 4, execute: {
print("4")
progress.completedUnitCount += 1
fulfill("4")
})
}
])
.then({ (_) in
print("DONE")
})
from promises.
Thank you!
But I don't see a progress passed as an argument to when
, as you proposed.
The example above can be rewritten as the following without any changes to the Promises APIs:
func subtask(_ overallProgress: Progress) -> Promise<Void> {
let progress = Progress(totalUnitCount: 10, parent: overallProgress, pendingUnitCount: 1)
return Promise<Void> {
guard isEverythingStillOK else {
progress.cancel()
throw MyError.somethingIsNotOK
}
progress.completedUnitCount = progress.totalUnitCount // Complete the child progress
return ()
}
}
let overallProgress = Progress(totalUnitCount: 2)
when(subtask(overallProgress), subtask(overallProgress)).then { _ in
// At least one subtask has succeeded
}
// Observe overallProgress.fractionCompleted
from promises.
@shoumikhin Sorry, I just added an example where this can be useful, I thought it will be a syntax sugar for someone who need Progress
i think something like this:
when([Promise<T>], progress: Progress? = nil)
from promises.
I do like the general idea. Although, at the moment, I believe it should be more involving than just passing an existing progress object to Promises APIs. Because if we went that way, that wouldn't be a big win, because one could track the progress separately, as I showed above. It's just not worth complicating the library APIs for something rarely used, that can be easily achieved the other clear way. But embedding progress reporting and cancellation into Promises would be great. We even have some prototypes internally and still working on that. Once we have anything working, I'll follow up here.
from promises.
Thank you
from promises.
Related Issues (20)
- Contextual type for closure argument list expects 1 argument, which cannot be implicitly ignored
- Objective-C Promises crashes in SwiftUI previews HOT 3
- ios 16 strings convertible to NSError HOT 1
- FBLPromises fails to load building macos flutter app HOT 2
- 'NSInvalidArgumentException', reason: '-[FBLPromise HTTPBody]: unrecognized selector sent to instance HOT 1
- Confused when retry a Promise variable
- type(of: value) is NSError.Type HOT 1
- Bitcode Issue on Xcode 13 when disable it. HOT 1
- Question regarding implementation HOT 3
- Ignore a certain Error and terminate Promise HOT 5
- Please release a new version of promises that includes latest changes for Firebase HOT 4
- Builds including PromisesSwift failing on CI
- Build fails for macOS with Xcode 14.3
- Create releases for new versions HOT 1
- The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 12.0 to 17.0.99.
- Privacy manifest for sensitive APIs HOT 6
- Version 2.4.0 not compiling HOT 15
- iOS build issue with 2.4.0 HOT 5
- PrivacyInfo.xcprivacy is not included in the framework output built by Carthage HOT 1
- FBLPromises.xcframework missing mac_catalyst support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from promises.