Git Product home page Git Product logo

Comments (6)

shoumikhin avatar shoumikhin commented on April 28, 2024 2

I believe handling ObjC exceptions is indeed an error prone overkill, so let's get rid of that behavior.
Many thanks for raising the issue, Tom!

from promises.

shali3 avatar shali3 commented on April 28, 2024

Hi @shoumikhin,
Looks like you haven't updated the docs regarding this behaviour.

from promises.

tomquist avatar tomquist commented on April 28, 2024

@shali3 The docs don't explicitly mention exceptions at all and in my opinion this is fine. The library doesn't catch exceptions anymore which is the default and expected behavior for any library in Objective C so it's not necessary to state that exceptions are not catched.

from promises.

shali3 avatar shali3 commented on April 28, 2024

From the docs (link in my previous comment):

Observing rejection
To get notified when a promise is resolved with an error (i.e. is rejected), use the catch operator.

You can reject a promise in many ways:

call reject method on a promise
call reject() in an async block or return an error from the do block
return or throw an error from the then block
Or, just create a resolved promise with an error.

from promises.

tomquist avatar tomquist commented on April 28, 2024

It's talking about throwing an error, not an exception which most probably refers to Swift Errors but you're right it's confusing at least. Maybe the word "Swift" should be added.

from promises.

shali3 avatar shali3 commented on April 28, 2024

From an ObjC perspective when I read error I think of NSError.

from promises.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.