Comments (3)
This seems reasonable to support and the change does look simple enough. I was going to ask whether the switch to hardcode llvm-symbolizer-14
means older version support would break but then I saw you mention explicitly that the code for that would be added.
The added benefit is that reading the JSON output is cleaner since this is clearly a machine-readable format. My only worry is whether this is going to be slower on large binaries - e.g. maybe LLVM is for any reason slower to produce JSON and parsing it would be added CPU time and RAM cost on the pprof side as well. It would be good to measure that at least in a couple of manual experiments.
from pprof.
Sounds good, thanks! I'll be sure to measure the performance.
I was going to ask whether the switch to hardcode
llvm-symbolizer-14
means older version support would break but then I saw you mention explicitly that the code for that would be added.
That change is just a hack. My machine didn't have llvm-symbolizer
in PATH (only variants with a version suffix), so I just hacked pprof's lookup code. That change won't be in a real PR.
from pprof.
Ack, thanks! Will review the PR when you have it (no rush, the pace is up to you).
from pprof.
Related Issues (20)
- Error & Troubleshooting HOT 1
- Support code coverage in javascript test HOT 1
- Add elf type and load segment information to mapping HOT 1
- pprof on MacOS can't find dot? HOT 3
- UI Support for tag commands: tagfocus, tagignore, tagshow, tagroot, etc HOT 1
- -tagroot and -tagleaf in UI aren't including the tag name? HOT 4
- New flame graph appears to reset the profile state in an unexpected way HOT 1
- If the file under the current path contains a colon, go tool pprof will parse it into a url and will not work properly.
- Compatibility guarantees for Profile-Guided Optimization (PGO) purposes with Go HOT 2
- Patch CVE for d3-color HOT 1
- make sources/sinks a different color HOT 2
- Canvas size related to initial size of a graph, should use the full space
- New flamegraph: 'hover shows details on the top' from old flame-graph missing
- Nice to have: 'grab' cursor when dragging the graph HOT 2
- How to load debug symbols from separately installed `-dbgsym` packages? HOT 7
- don't need profile after convert HOT 1
- Pprof does not resolve symbols HOT 1
- [Help Needed] How to Accelerate `pprof -top` Command Execution for Profiling Data? HOT 2
- extended dependencies because of browser test HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pprof.