Problem with std::max about pik HOT 8 CLOSED

Thank you for reporting this! We'll fix it in the next push. In the meantime, you can replace those two lines with
return std::min(std::max<int64_t>(0, coord), size - 1); and
num_instances_(std::max<size_t>(pool->NumThreads(), 1)) {

from pik.

Thanks

from pik.

I believe this is fixed; if not, please feel free to re-open.

from pik.

This is fixed, but I don't know, how should codec work properly with gcc?
I use gcc 9.00. I don't know, can newer versions of butteraugli be used? It has other recording.
I have problem with new brotli. The files are missing
I have problem with decoder. It doesn't work.
I have problem with function thread. Does it work with implementation mingw-std-threads-master.zip for Windows.

from pik.

Interestingly our Travis build uses an ancient GCC 4.8.4 but it compiles fine. What error do you see?

To get Brotli, git submodule init && git submodule update (as the Makefile says).
What problems do you have with decoder/threads?

from pik.

I will add opensource and codec pik:
https://www.sendspace.com/file/yhh7rl
The encoder command line:
cpik_google_none.exe input.png output.pik --distance 3.0 --num_threads 0
dpik_google_none.exe --num_threads 0 output.pik output.png
When the number of cores is greater than zero, the encoder doesn't create pik images.
The decoder doesn't want to create files png.
I don't know, there is no specified value zu.
Compressing zu x zu pixels with maximum Butteraugli distance 3.000000, zu threads.
Compressed to zu bytes (0.00 MB/s).
Read zu compressed bytes
Failed to decompress.

I use:
http://msystem.waw.pl/x265/mingw-gcc900-20180628.7z

from pik.

I believe the zu format string issue has since been fixed. Is this an older binary?
If you are able to compile and link with -fsanitize=address, and add these after the include guard in status.h: #define PIK_ENABLE_ASSERT
#define PIK_CRASH_ON_ERROR then we might be able to help diagnose the problem :)

from pik.

I believe the zu format string issue has since been fixed. Is this an older binary?

Brotli work correct, add patch version 27.06.2018

I have Windows no Linux. A little inconvenience that I will not preview the value of zu.
I add #define PIK_ENABLE_ASSERT and #define PIK_CRASH_ON_ERROR
I can't add -fsanitize=address for Windows. :(
I has communique error:
Pik assert failed at write_bits.h:47

from pik.