Build fails on macOS due to undeclared type '__m128i' in cache_aligned.h about pik HOT 5 CLOSED

Hi Vlad, thank you for reporting this. We're working on a fix that will also hide x86-specific code behind an ifdef.

Yes, we currently do require AVX2 - we're adding similar checks using instruction_sets.h Supported.

from pik.

Hi Jan,

All good. Closing the issue.

from pik.

Had to also add JPG_FLAGS := $(shell pkg-config --cflags libjpeg) and JPG_LIBS := $(shell pkg-config --libs libjpeg) to Makefile and install zlib as the system one does not have pkg-config.

Even though it fixed the issue, the compiled binary crashes when trying to encode a PNG/JPEG file. Using macOS Sierra 10.12.6, Intel Core i7, libpng 1.6.32 and libjpeg-turbo 1.5.2.

* thread #1, queue = 'com.apple.main-thread', stop reason = EXC_BAD_INSTRUCTION (code=EXC_I386_INVOP, subcode=0x0)
    frame #0: 0x0000000100043111 cpik`pik::ComputeTransposedScaledBlockDCTFloat(float*) [inlined] pik::ColumnDCT(block=0x00007fff5fbfe3e0) at dct.cc:145
   142 	  const V t19 = c2 * t16;
   143 	  const V t20 = t01 + t18;
   144 	  const V t21 = t01 - t18;
-> 145 	  const V t22(_mm256_fmsub_ps(c3, t13, t19));
   146 	  const V t23(_mm256_fmsub_ps(c4, t14, t19));
   147 	  Store(t08 + t10, &block[ 0]);
   148 	  Store(t20 + t22, &block[ 8]);

Edit: It turns out my CPU does not support AVX2 and FMA. Maybe these checks will be helpful.

int main(int argc, char** argv) {
  if(!__builtin_cpu_supports("avx2") || !__builtin_cpu_supports("fma")) {
    printf("AVX2 and FMA support is required.\n");
    return 1;
  }

from pik.

Done (including exiting if non-AVX2 CPU).
We will also add support for other CPUs in the medium term.

from pik.

Thanks for letting us know :D

from pik.