Git Product home page Git Product logo

Comments (5)

andrewpollock avatar andrewpollock commented on June 10, 2024 1

Additionally, thank you for your feedback, and if you have any data quality observations on the records (at https://storage.googleapis.com/osv-vulnerabilities/index.html?prefix=GIT/ in particular) please file issues to capture them.

from osv.dev.

oliverchang avatar oliverchang commented on June 10, 2024

Hi @yashrsharma44 , thanks for the issue!

The versions entry follows the standard of the ecosystem specified in package. This is the same for versions specified in ranges.

For example, https://osv.dev/vulnerability/GHSA-9wmf-xf3h-r8pr is for the Maven ecosystem, and the OSV JSON looks like:

"affected": [
    {
      "package": {
        "name": "org.jberet:jberet-core",
        "ecosystem": "Maven",
        "purl": "pkg:maven/org.jberet/jberet-core"
      },
      "ranges": [
        {
          "type": "ECOSYSTEM",
          "events": [
            {
              "introduced": "0"
            },
            {
              "fixed": "2.2.1.Final"
            }
          ]
        }
      ],
      "versions": [
        "1.0.0.Alpha1",
        "1.0.0.Alpha2",
        "1.0.0.Alpha3",
        "1.0.0.Alpha4",
        "1.0.0.Beta1",
        "1.0.0.Beta2",
        "1.0.0.CR1",
        "1.0.0.CR2",
        "1.0.0.Final",
        "1.0.1.Beta",
        ...

Where every version listed is a version in the Maven registry, following Maven's version numbering rules.

Where this is a bit more complicated is when there is no well-defined packaging ecosystem specified, like for general C/C++ libraries (i.e. there are only GIT version ranges). In this case, the values formats are technically undefined according to the spec, but in OSV.dev's case, this typically means this is the upstream git version tags derived from the given GIT commit ranges. In these cases, the GIT commit ranges should be used to match git commit hashes to vulnerabilities.

Does this answer your question?

from osv.dev.

yashrsharma44 avatar yashrsharma44 commented on June 10, 2024

Hi @yashrsharma44 , thanks for the issue!

The versions entry follows the standard of the ecosystem specified in package. This is the same for versions specified in ranges.

For example, https://osv.dev/vulnerability/GHSA-9wmf-xf3h-r8pr is for the Maven ecosystem, and the OSV JSON looks like:

"affected": [
    {
      "package": {
        "name": "org.jberet:jberet-core",
        "ecosystem": "Maven",
        "purl": "pkg:maven/org.jberet/jberet-core"
      },
      "ranges": [
        {
          "type": "ECOSYSTEM",
          "events": [
            {
              "introduced": "0"
            },
            {
              "fixed": "2.2.1.Final"
            }
          ]
        }
      ],
      "versions": [
        "1.0.0.Alpha1",
        "1.0.0.Alpha2",
        "1.0.0.Alpha3",
        "1.0.0.Alpha4",
        "1.0.0.Beta1",
        "1.0.0.Beta2",
        "1.0.0.CR1",
        "1.0.0.CR2",
        "1.0.0.Final",
        "1.0.1.Beta",
        ...

Where every version listed is a version in the Maven registry, following Maven's version numbering rules.

Where this is a bit more complicated is when there is no well-defined packaging ecosystem specified, like for general C/C++ libraries (i.e. there are only GIT version ranges). In this case, the values formats are technically undefined according to the spec, but in OSV.dev's case, this typically means this is the upstream git version tags derived from the given GIT commit ranges. In these cases, the GIT commit ranges should be used to match git commit hashes to vulnerabilities.

Does this answer your question?

Thanks for the response. I agree with the versions returned; would be nice if we have this documented somewhere, ideally in the OSV Schema itself. The git tags are indeed useful, as the tags can be used for matching the version(or if it doesn't exist).

Thanks for maintaining this awesome archive 😄

from osv.dev.

yashrsharma44 avatar yashrsharma44 commented on June 10, 2024

Additionally, thank you for your feedback, and if you have any data quality observations on the records (at https://storage.googleapis.com/osv-vulnerabilities/index.html?prefix=GIT/ in particular) please file issues to capture them.

My pleasure. I will add more GH issues, as I find any discrepancies in the data.

from osv.dev.

andrewpollock avatar andrewpollock commented on June 10, 2024

Thanks for the response. I agree with the versions returned; would be nice if we have this documented somewhere, ideally in the OSV Schema itself. The git tags are indeed useful, as the tags can be used for matching the version(or if it doesn't exist).

@yashrsharma44 Please take a look at ossf/osv-schema#238 and provide any feedback on how well you feel it addresses this deficiency in the schema documentation.

from osv.dev.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.