Compilation failure (in kafel?) with GCC 8.1 about nsjail HOT 7 CLOSED

Please try with 21a7bbb

from nsjail.

No, if you want to fix it that way, you should just pass -Wno-format-truncation instead. Which works, while your change does not. ;)

from nsjail.

(I’m building with sed -i 's/-Wno-format-nonliteral/-Wno-format-nonliteral -Wno-format-truncation/' Makefile, but reported the issue so that it could be fixed properly)

from nsjail.

-Wno-format-truncation is unrecognized with earlier g++/clang++, so cannot add it directly.

I guess I'll rewrite the cgroups.cc at some point, though the current snprintf() use is correct, and the warning is too greedy

from nsjail.

Didn’t thought about that. Well if you think that GCC is wrong in outputing such warnings (I admit having insufficient knowledge to tell about that), maybe you should report it to them. They have also been issues with unused variables specified as such triggering the -Wunused-variables for instance in GCC8.

from nsjail.

The warning also for me seems a little to greedy, but I refactored the code to use std::string.
I was able to compile it cleanly with GCC 8, but would be nice if u could verify it too and let me know.

from nsjail.

Works for me too. ;)

from nsjail.