Git Product home page Git Product logo

Comments (11)

PiotrSikora avatar PiotrSikora commented on May 3, 2024

They are built by default, the line you've added is part of generated Makefile in nginx-1.9.11, see: http://hg.nginx.org/nginx/diff/85dea406e18f/auto/install.

from ngx_brotli.

badfiles avatar badfiles commented on May 3, 2024

This is the result I get

cp  objs/ngx_http_brotli_static_module.so objs/ngx_http_brotli_filter_module.so '/usr/nginx/modules'
cp: cannot stat ‘objs/ngx_http_brotli_static_module.so’: No such file or directory
cp: cannot stat ‘objs/ngx_http_brotli_filter_module.so’: No such file or directory
make[1]: *** [install] Error 1
make[1]: Leaving directory `/src/nginx-1.9.11'

objs/addon/src is also empty,
so I have to manually compile modules.
My config

./configure --prefix=/usr/nginx   \
        --add-dynamic-module=ngx_brotli/ \
        --with-file-aio \
        --with-http_ssl_module \
        --with-http_realip_module \
        --with-http_gunzip_module \
        --with-http_gzip_static_module \
        --with-threads \
        --with-http_v2_module 

(but with add-module everything works great)

from ngx_brotli.

PiotrSikora avatar PiotrSikora commented on May 3, 2024

Weird... Are you using stock nginx-1.9.11 or patched version? Also, could you post complete output of ./configure --add-dynamic-module=ngx_brotli, make and make install?

from ngx_brotli.

badfiles avatar badfiles commented on May 3, 2024

Last time I tested with rev ba3c2ca21aa5,
having removed this code from module config
CFLAGS="$CFLAGS -Wno-write-strings"
I make with checkinstall, the output you requested will be in a while.

from ngx_brotli.

badfiles avatar badfiles commented on May 3, 2024

out.txt

from ngx_brotli.

PiotrSikora avatar PiotrSikora commented on May 3, 2024

Thanks! That was helpful. Do you have a name that I should add to the commit message or is "Reported by badfiles on GitHub" fine with you?

from ngx_brotli.

badfiles avatar badfiles commented on May 3, 2024

yep

from ngx_brotli.

PiotrSikora avatar PiotrSikora commented on May 3, 2024

http://mailman.nginx.org/pipermail/nginx-devel/2016-February/007909.html

from ngx_brotli.

RaeesBhatti avatar RaeesBhatti commented on May 3, 2024

Has this been fixed?

from ngx_brotli.

PiotrSikora avatar PiotrSikora commented on May 3, 2024

I believe it was fixed in http://hg.nginx.org/nginx/rev/cfc3cfa434ec (nginx-1.9.12), why do you ask?

from ngx_brotli.

RaeesBhatti avatar RaeesBhatti commented on May 3, 2024

I am going to compile nginx with this module as dynamic. So, just checking if there are any issues I should be aware of.

from ngx_brotli.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.