Is send window scale wrong? about netstack HOT 4 CLOSED

Hmm, looks wrong to me. @hbhasker, thoughts?

from netstack.

For reference, this was added in 9527cbd#diff-04661a3cf15a0f0b7871767d7208e024R273

from netstack.

This is correct. What this is doing is scaling the window if window scaling was enabled. This basically stores the send window based on the advertised window in the last ack of the TCP handshake.

See from rfc 1323.

The window field (SEG.WND) in the header of every incoming
segment, with the exception of SYN segments, is left-shifted
by Snd.Wind.Scale bits before updating SND.WND:

          SND.WND = SEG.WND << Snd.Wind.Scale

       (assuming the other conditions of RFC793 are met, and using
       the "C" notation "<<" for left-shift).

from netstack.

Oh yes, you are right!

from netstack.