Git Product home page Git Product logo

Comments (5)

SirSykon avatar SirSykon commented on April 30, 2024

No. I'm trying to understand how the code works and I've tested the brdf_mlp with some random values obtaining very high values (10 e6). Since albedo is between 0 and 1, the differences between scales are strange andthat's the reason I was curious about the brdf_scale but I think is 1.

Is it the expected mlp_brdf to return so high values?

from nerfactor.

malfonsoarquimea avatar malfonsoarquimea commented on April 30, 2024

I am having a similar problem. I am doing some modifications to the code and now, I see that the brdf_mlp produces very large values ranging from 1e4 to 1e6 or so. This results on the albedo being not optimized as the final RGB value depends mostly on the specular, which has much higher values than the albedo

from nerfactor.

xiumingzhang avatar xiumingzhang commented on April 30, 2024

Hi both, that constant for scaling the BRDF is an artificial scale set empirically. The reason is that the unit of BRDFs is often ambiguous and not physically rigorous. For example, when we pretrained our BRDF MLP on the MERL BRDFs, it was unclear what unit the MERL BRDFs used. Plus, the light probe intensities are not metric either, so somewhere along the rendering pipeline, one would need some scaling, whether at the BRDF output or the final rendering. Feel free to reopen this if you need further help.

from nerfactor.

SirSykon avatar SirSykon commented on April 30, 2024

Hello!
I understand your answer but checking the configuration, brdf_scale seems to be 1 so it would be the same to ignore it. Should it be changed for each scene?
Thanks

from nerfactor.

xiumingzhang avatar xiumingzhang commented on April 30, 2024

Hi @SirSykon. Shouldn't need to change that for each scene. Usually, we set one brdf_scale for each BRDF pertaining dataset (e.g., the MERL dataset) because that's what determines the "scale."

from nerfactor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.