Can't install publicsuffic=x per instruction about namebench HOT 7 CLOSED

When you visit that url it redirects to github.com/golang/go. I'm able to grab publicsuffix by pulling from golang.org:

$ go get golang.org/x/net/publicsuffix

And changing the import line in history/filter.go to reflect this change:

@@ -4,3 +4,3 @@
 import (
-	"code.google.com/p/go.net/publicsuffix"
+	"golang.org/x/net/publicsuffix"
 	"log"

Though I still have the same problem as you where it seems to be looking for for an OSX-style path

from namebench.

Thank you, I had the same problem, will someone please fix filter.go?

from namebench.

The instructions in README.md still says go get code.google.com/p/go.net/publicsuffix which fails for me so:-

package code.google.com/p/go.net/publicsuffix: unrecognized import path "code.google.com/p/go.net/publicsuffix" (parse https://code.google.com/p/go.net/publicsuffix?go-get=1: no go-import meta tags (meta tag github.com/golang/go did not match import path code.google.com/p/go.net/publicsuffix))

from namebench.

@Chaz6 did you read this comment above? That change will let you build the project.

You can also just grab the code from my PR; that’ll sort you out, too.

from namebench.

Yes, just pointing out that the README also needs updating.

from namebench.

@Chaz6 yep, I’ve had it corrected in my PR for a while: https://github.com/google/namebench/pull/9/files#diff-04c6e90faac2675aa89e2176d2eec7d8R31

Maybe one day @tstromberg will get a chance to merge it in 🤞

from namebench.

🎉 celebrate, one & all!

from namebench.