Consider making the tests follow JUnit 5 idioms more closely about mug HOT 5 CLOSED

Thanks!

from mug.

Only reason JUnit 5 was included was to have assertThrows().

Inside Google, we use JU4 with backported assertThrows().

I guess we could migrate to JU5. My only concern would be the deviation from Google's internal tests, making it harder to move code one way or another.

from mug.

Only reason JUnit 5 was included was to have assertThrows().

Inside Google, we use JU4 with backported assertThrows().

Ah okay, I see. That makes sense to me.

I guess we could migrate to JU5. My only concern would be the deviation from Google's internal tests, making it harder to move code one way or another.

Okay, I think I understand your concerns here.

How about we change the pom.xmls so that rather than importing junit-platform-runner, they import junit:junit:4.x instead?

That way, it's more explicit (in my mind at least) that we're still using JUnit 4 as the underlying "test engine", but that we're merely importing org.junit.jupiter:junit-jupiter-api:5.0.0-M3 to have access to assertThrows() (in a similar way to how we currently use Truth to have access to more assertions).

from mug.

Sounds good! Care to send a PR? :)

from mug.

Happily! :)

Here's the PR, FYI.

from mug.