Git Product home page Git Product logo

Comments (4)

smalls avatar smalls commented on May 9, 2024

from model-viewer.

cdata avatar cdata commented on May 9, 2024

Echoing discussion in #61 (comment)

I think it's fine to pick any given default. However, I also think it's important to give the content author control over what is actually shown to the end user. They may not want a "present in AR" button in some contexts or at all. A boolean configuration is an easy way to enable this flexibility.

from model-viewer.

cdata avatar cdata commented on May 9, 2024

Related to this topic, the ar attribute might be better as an ar-controls attribute. Instead of thinking of it as enabling or disabling AR altogether, we should think of it as enabling or disabling the built-in controls for launching AR.

from model-viewer.

jsantell avatar jsantell commented on May 9, 2024

I think that "AR" (WebXR, ML, iOS, etc.) should be the default, and if for some reason, someone's visiting this content on Helio, Chrome Canary with WebXR flags, or on iOS with a USDZ provided, which is already a terribly small subset of users, it "just works" without having to opt in. This is part of the "works out of the box" story, rather than needing to explicitly enable, or worse, enable for different AR platforms (would have to keep up to date on what is supported, and update content accordingly). If a developer wanted to explicitly disable AR, we could provide a disable-ar attribute, or disable-{webxr|magicleap} for individual platforms.

We should make this work by default with AR, and have an attribute for the exceptional case. Thoughts?

from model-viewer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.