Git Product home page Git Product logo

Comments (4)

qhdqhd avatar qhdqhd commented on May 2, 2024

@jonbarron

from mipnerf.

wuzirui avatar wuzirui commented on May 2, 2024

same question here:
since $$Var[r]=E[r^2]-E[r]^2=E[x^2]+E[y^2]-E[r]^2,$$
$$E[r] = \iiint rt\cdot r\text{d}r\text{d}t\text{d}\theta=\frac{\pi}{3}\dot{r}^3(t_1^3-t_0^3) $$

which does not correspond to the results in the supplementary materials @jonbarron

from mipnerf.

jonbarron avatar jonbarron commented on May 2, 2024

Hi everyone, thanks for helping investigate this! It seems like there's almost certainly a bug in the math where I missed a 2x multiplier. My mistake, sorry! This explains a lot, as we've noticed other places in the math where we seem to be wrong by a factor of two. I will dig into this and attempt to fix it --- though if anyone else wants to patch the math and push a CL with updated unit tests, feel free!

from mipnerf.

qhdqhd avatar qhdqhd commented on May 2, 2024

I don't know if this improvement will improve the effect? The fitting ability of neural networks is too strong, may a difference of two times not affect the results too much? Look forward to your reply!

from mipnerf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.