Don't allow dividing by 0 about mathsteps HOT 11 OPEN

I am on this; will PR soon. How should we handle the 0/0 case? Return DIVIDE_BY_ZERO too?

from mathsteps.

yeah, I think I'm comfy having them give the same error. Sound ok to you?

from mathsteps.

Yes I think that makes sense! I'll PR later tonight.

from mathsteps.

Hey @hmaurer, I see you have a branch open for this and a commit - did you forget to put up a PR or did you want to work on it a bit more first?

from mathsteps.

@hmaurer ?

from mathsteps.

@evykassirer Sorry for the delay; I have opened a PR

edit: will do in 5min, I first need to merge master and there are conflicts :(

from mathsteps.

no problem at all, just wanted to make sure it wasn't forgotten about ^_^

from mathsteps.

This is interesting, I wonder if there should be a NodeStatus for errors like this in general that we check, not just divide by zero.

from mathsteps.

@aelnaiem I was thinking about that too!

In the PR, I talked about:

oh, maybe a nodeStatus should have both a changeType and an errorType (default to null)? idk, still trying to figure out what this would look like long term

what do you think?

from mathsteps.

Yea I think that's a good idea!

from mathsteps.

UPDATE: now related to #129 -- let's use it as the first error that we implement with the new error structure

I removed the small label, since this is more complicated now

from mathsteps.