Git Product home page Git Product logo

Comments (10)

unknownkid avatar unknownkid commented on May 3, 2024 3

Using the hack method in tensorflow/tensorflow#31190, Lyra can be build on MacOS.

  1. run the compile command: "bazel build....", it will failed as above, and the Build.bazel files (2 files) wii be created in Lyra folder.
  2. commented the code blocks below in 2 Build.bazel files:

Block 01

# config_setting(
#     name = "osx",
#     constraint_values = [
#         "@bazel_tools//platforms:osx",
#     ],
# )
#
# config_setting(
#     name = "ios",
#     constraint_values = [
#         "@bazel_tools//platforms:ios",
#     ],
# )

...

Block 02

# linkopts = select({
#     ":osx": [
#         "-framework Foundation",
#     ],
#     ":ios": [
#         "-framework Foundation",
#     ],
#     "//conditions:default": [],
# }),
  1. And run the compile command again, it work.

from lyra.

a-rose avatar a-rose commented on May 3, 2024 1

For what it's worth, I was able to build on MacOS using Debian in Docker (Dockerfile here: #10 (comment))

from lyra.

aluebs avatar aluebs commented on May 3, 2024

Thank you for your detailed report. Currently we only support building for Linux and Android.

from lyra.

hitrefresh avatar hitrefresh commented on May 3, 2024

This was building the Android example, but does that have to be done on a Linux machine?

from lyra.

aluebs avatar aluebs commented on May 3, 2024

Currently, a Linux machine es necessary to build the Android example, but maybe @mchinen can comment on building on Mac.

from lyra.

mchinen avatar mchinen commented on May 3, 2024

As @aluebs mentioned we officially only support linux development machines, but in theory a mac should be able to build, and it's probably not too hard to get experimental support for android builds on mac.

I'm not sure when we'll get to look deeper into this but I took a peek. In case you or others want to dive in, the issue you are running into appears to link in the mac Foundation framework into an android target for some reason, likely due to the (external) abseil project incorrectly setting up mac deps.
It is probably related to tensorflow/tensorflow#31190
and
abseil/abseil-cpp#326

The ideal fix is likely in the abseil repo, but a local workaround is described in those issues.

from lyra.

aigeek avatar aigeek commented on May 3, 2024

Using the hack method in tensorflow/tensorflow#31190, Lyra can be build on MacOS.

  1. run the compile command: "bazel build....", it will failed as above, and the Build.bazel files (2 files) wii be created in Lyra folder.
  2. commented the code blocks below in 2 Build.bazel files:

Block 01

# config_setting(
#     name = "osx",
#     constraint_values = [
#         "@bazel_tools//platforms:osx",
#     ],
# )
#
# config_setting(
#     name = "ios",
#     constraint_values = [
#         "@bazel_tools//platforms:ios",
#     ],
# )

...

Block 02

# linkopts = select({
#     ":osx": [
#         "-framework Foundation",
#     ],
#     ":ios": [
#         "-framework Foundation",
#     ],
#     "//conditions:default": [],
# }),
  1. And run the compile command again, it work.

Hi,Thanks,but I Can not find " the Build.bazel files (2 files) wii be created in Lyra folder":
@ unknownkid @aluebs
Is it in this folder?

➜ lyra git:(main) ✗ ls
BUILD external no_op_preprocessor_test.cc
CONTRIBUTING.md feature_extractor_interface.h noise_estimator.cc
Doxyfile filter_banks.cc noise_estimator.h
LICENSE filter_banks.h noise_estimator_interface.h
README.md filter_banks_interface.h noise_estimator_test.cc
WORKSPACE filter_banks_test.cc packet.h
WORKSPACE.bak generative_model_interface.h packet_interface.h
android_example gilbert_model.cc packet_loss_handler.cc
architecture_utils.h gilbert_model.h packet_loss_handler.h
bazel-bin gilbert_model_test.cc packet_loss_handler_interface.h
bazel-lyra layer_wrapper.h packet_loss_handler_test.cc
bazel-out layer_wrapper_interface.h packet_test.cc
bazel-testlogs layer_wrapper_test_common.h preprocessor_interface.h
benchmark_decode.cc layer_wrappers_lib.h project_and_sample.h
benchmark_decode_lib.cc lib project_and_sample_test.cc
benchmark_decode_lib.h log_mel_spectrogram_extractor_impl.cc quadrature_mirror_filter.cc
buffer_merger.cc log_mel_spectrogram_extractor_impl.h quadrature_mirror_filter.h
buffer_merger.h log_mel_spectrogram_extractor_impl_benchmark.cc quadrature_mirror_filter_test.cc
buffer_merger_test.cc log_mel_spectrogram_extractor_impl_test.cc resampler.cc
causal_convolutional_conditioning.h lyra_components.cc resampler.h
causal_convolutional_conditioning_test.cc lyra_components.h resampler_interface.h
comfort_noise_generator.cc lyra_config.cc resampler_test.cc
comfort_noise_generator.h lyra_config.h sparse_inference_matrixvector.h
comfort_noise_generator_test.cc lyra_config.proto sparse_inference_matrixvector_test.cc
conv1d_layer_wrapper.h lyra_config_test.cc spectrogram_predictor_interface.h
conv1d_layer_wrapper_test.cc lyra_decoder.cc testdata
decoder_main.cc lyra_decoder.h testing
decoder_main_lib.cc lyra_decoder_interface.h toolchain
decoder_main_lib.h lyra_decoder_test.cc transpose_convolutional_layer_wrapper.h
decoder_main_lib_test.cc lyra_encoder.cc transpose_convolutional_layer_wrapper_test.cc
denoiser_interface.h lyra_encoder.h vector_quantizer_impl.cc
dilated_convolutional_layer_wrapper.h lyra_encoder_interface.h vector_quantizer_impl.h
dilated_convolutional_layer_wrapper_test.cc lyra_encoder_test.cc vector_quantizer_impl_test.cc
dsp_util.cc lyra_integration_test.cc vector_quantizer_interface.h
dsp_util.h lyra_types.h wav_util.cc
dsp_util_test.cc lyra_wavegru.h wav_util.h
encoder_main.cc lyra_wavegru_test.cc wav_util_test.cc
encoder_main_lib.cc naive_spectrogram_predictor.cc wavegru
encoder_main_lib.h naive_spectrogram_predictor.h wavegru_model_impl.cc
encoder_main_lib_test.cc naive_spectrogram_predictor_test.cc wavegru_model_impl.h
exported_layers_test.h no_op_preprocessor.h wavegru_model_impl_test.cc

from lyra.

wikipedia2008 avatar wikipedia2008 commented on May 3, 2024

Using the hack method in tensorflow/tensorflow#31190, Lyra can be build on MacOS.

  1. run the compile command: "bazel build....", it will failed as above, and the Build.bazel files (2 files) wii be created in Lyra folder.
  2. commented the code blocks below in 2 Build.bazel files:

Block 01

# config_setting(
#     name = "osx",
#     constraint_values = [
#         "@bazel_tools//platforms:osx",
#     ],
# )
#
# config_setting(
#     name = "ios",
#     constraint_values = [
#         "@bazel_tools//platforms:ios",
#     ],
# )

...

Block 02

# linkopts = select({
#     ":osx": [
#         "-framework Foundation",
#     ],
#     ":ios": [
#         "-framework Foundation",
#     ],
#     "//conditions:default": [],
# }),
  1. And run the compile command again, it work.

Hi,Thanks,but I Can not find " the Build.bazel files (2 files) wii be created in Lyra folder":
@ unknownkid @aluebs
Is it in this folder?

➜ lyra git:(main) ✗ ls
BUILD external no_op_preprocessor_test.cc
CONTRIBUTING.md feature_extractor_interface.h noise_estimator.cc
Doxyfile filter_banks.cc noise_estimator.h
LICENSE filter_banks.h noise_estimator_interface.h
README.md filter_banks_interface.h noise_estimator_test.cc
WORKSPACE filter_banks_test.cc packet.h
WORKSPACE.bak generative_model_interface.h packet_interface.h
android_example gilbert_model.cc packet_loss_handler.cc
architecture_utils.h gilbert_model.h packet_loss_handler.h
bazel-bin gilbert_model_test.cc packet_loss_handler_interface.h
bazel-lyra layer_wrapper.h packet_loss_handler_test.cc
bazel-out layer_wrapper_interface.h packet_test.cc
bazel-testlogs layer_wrapper_test_common.h preprocessor_interface.h
benchmark_decode.cc layer_wrappers_lib.h project_and_sample.h
benchmark_decode_lib.cc lib project_and_sample_test.cc
benchmark_decode_lib.h log_mel_spectrogram_extractor_impl.cc quadrature_mirror_filter.cc
buffer_merger.cc log_mel_spectrogram_extractor_impl.h quadrature_mirror_filter.h
buffer_merger.h log_mel_spectrogram_extractor_impl_benchmark.cc quadrature_mirror_filter_test.cc
buffer_merger_test.cc log_mel_spectrogram_extractor_impl_test.cc resampler.cc
causal_convolutional_conditioning.h lyra_components.cc resampler.h
causal_convolutional_conditioning_test.cc lyra_components.h resampler_interface.h
comfort_noise_generator.cc lyra_config.cc resampler_test.cc
comfort_noise_generator.h lyra_config.h sparse_inference_matrixvector.h
comfort_noise_generator_test.cc lyra_config.proto sparse_inference_matrixvector_test.cc
conv1d_layer_wrapper.h lyra_config_test.cc spectrogram_predictor_interface.h
conv1d_layer_wrapper_test.cc lyra_decoder.cc testdata
decoder_main.cc lyra_decoder.h testing
decoder_main_lib.cc lyra_decoder_interface.h toolchain
decoder_main_lib.h lyra_decoder_test.cc transpose_convolutional_layer_wrapper.h
decoder_main_lib_test.cc lyra_encoder.cc transpose_convolutional_layer_wrapper_test.cc
denoiser_interface.h lyra_encoder.h vector_quantizer_impl.cc
dilated_convolutional_layer_wrapper.h lyra_encoder_interface.h vector_quantizer_impl.h
dilated_convolutional_layer_wrapper_test.cc lyra_encoder_test.cc vector_quantizer_impl_test.cc
dsp_util.cc lyra_integration_test.cc vector_quantizer_interface.h
dsp_util.h lyra_types.h wav_util.cc
dsp_util_test.cc lyra_wavegru.h wav_util.h
encoder_main.cc lyra_wavegru_test.cc wav_util_test.cc
encoder_main_lib.cc naive_spectrogram_predictor.cc wavegru
encoder_main_lib.h naive_spectrogram_predictor.h wavegru_model_impl.cc
encoder_main_lib_test.cc naive_spectrogram_predictor_test.cc wavegru_model_impl.h
exported_layers_test.h no_op_preprocessor.h wavegru_model_impl_test.cc

bazel-lyra/external/com_google_absl/absl/time/internal/cctz/BUILD.bazel

from lyra.

qingkouwei avatar qingkouwei commented on May 3, 2024

Using the hack method in tensorflow/tensorflow#31190, Lyra can be build on MacOS.

  1. run the compile command: "bazel build....", it will failed as above, and the Build.bazel files (2 files) wii be created in Lyra folder.
  2. commented the code blocks below in 2 Build.bazel files:

Block 01

# config_setting(
#     name = "osx",
#     constraint_values = [
#         "@bazel_tools//platforms:osx",
#     ],
# )
#
# config_setting(
#     name = "ios",
#     constraint_values = [
#         "@bazel_tools//platforms:ios",
#     ],
# )

...

Block 02

# linkopts = select({
#     ":osx": [
#         "-framework Foundation",
#     ],
#     ":ios": [
#         "-framework Foundation",
#     ],
#     "//conditions:default": [],
# }),
  1. And run the compile command again, it work.

Hi,Thanks,but I Can not find " the Build.bazel files (2 files) wii be created in Lyra folder":
@ unknownkid @aluebs
Is it in this folder?

➜ lyra git:(main) ✗ ls
BUILD external no_op_preprocessor_test.cc
CONTRIBUTING.md feature_extractor_interface.h noise_estimator.cc
Doxyfile filter_banks.cc noise_estimator.h
LICENSE filter_banks.h noise_estimator_interface.h
README.md filter_banks_interface.h noise_estimator_test.cc
WORKSPACE filter_banks_test.cc packet.h
WORKSPACE.bak generative_model_interface.h packet_interface.h
android_example gilbert_model.cc packet_loss_handler.cc
architecture_utils.h gilbert_model.h packet_loss_handler.h
bazel-bin gilbert_model_test.cc packet_loss_handler_interface.h
bazel-lyra layer_wrapper.h packet_loss_handler_test.cc
bazel-out layer_wrapper_interface.h packet_test.cc
bazel-testlogs layer_wrapper_test_common.h preprocessor_interface.h
benchmark_decode.cc layer_wrappers_lib.h project_and_sample.h
benchmark_decode_lib.cc lib project_and_sample_test.cc
benchmark_decode_lib.h log_mel_spectrogram_extractor_impl.cc quadrature_mirror_filter.cc
buffer_merger.cc log_mel_spectrogram_extractor_impl.h quadrature_mirror_filter.h
buffer_merger.h log_mel_spectrogram_extractor_impl_benchmark.cc quadrature_mirror_filter_test.cc
buffer_merger_test.cc log_mel_spectrogram_extractor_impl_test.cc resampler.cc
causal_convolutional_conditioning.h lyra_components.cc resampler.h
causal_convolutional_conditioning_test.cc lyra_components.h resampler_interface.h
comfort_noise_generator.cc lyra_config.cc resampler_test.cc
comfort_noise_generator.h lyra_config.h sparse_inference_matrixvector.h
comfort_noise_generator_test.cc lyra_config.proto sparse_inference_matrixvector_test.cc
conv1d_layer_wrapper.h lyra_config_test.cc spectrogram_predictor_interface.h
conv1d_layer_wrapper_test.cc lyra_decoder.cc testdata
decoder_main.cc lyra_decoder.h testing
decoder_main_lib.cc lyra_decoder_interface.h toolchain
decoder_main_lib.h lyra_decoder_test.cc transpose_convolutional_layer_wrapper.h
decoder_main_lib_test.cc lyra_encoder.cc transpose_convolutional_layer_wrapper_test.cc
denoiser_interface.h lyra_encoder.h vector_quantizer_impl.cc
dilated_convolutional_layer_wrapper.h lyra_encoder_interface.h vector_quantizer_impl.h
dilated_convolutional_layer_wrapper_test.cc lyra_encoder_test.cc vector_quantizer_impl_test.cc
dsp_util.cc lyra_integration_test.cc vector_quantizer_interface.h
dsp_util.h lyra_types.h wav_util.cc
dsp_util_test.cc lyra_wavegru.h wav_util.h
encoder_main.cc lyra_wavegru_test.cc wav_util_test.cc
encoder_main_lib.cc naive_spectrogram_predictor.cc wavegru
encoder_main_lib.h naive_spectrogram_predictor.h wavegru_model_impl.cc
encoder_main_lib_test.cc naive_spectrogram_predictor_test.cc wavegru_model_impl.h
exported_layers_test.h no_op_preprocessor.h wavegru_model_impl_test.cc

bazel-lyra/external/com_google_absl/absl/time/internal/cctz/BUILD.bazel and bazel-lyra/external/com_google_absl/absl/BUILD.bazel

from lyra.

aluebs avatar aluebs commented on May 3, 2024

The new Lyra 1.2.0 release has experimental Mac support. So hopefully this should be fixed now.

from lyra.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.