Comments (4)
I'm getting the same behavior.
In my tests I set up logger like so testLogger := logger.Init("Test", false, false, ioutil.Discard)
, but still ERROR messages go to stdout. I wouldn't mind working on this if someone from the core team gave me some guidance on how to proceed.
EDIT:
After a little digging, I believe logger.go#L97 is causing the issue. This could be resolved by moving the line inside the if verbose {...}
, or adding an option for skipping the eLogs = append(eLogs, os.Stderr)
.
from logger.
There's not a simple way to get this functionality and keep the API surface for existing users. In our other loggers we moved to options so we could add features like this, but that would be a breaking change here. We could add options on top of the existing arguments to Init though, right now 'stdout' would be the only option.
from logger.
Would it be safe to skip eLogs = append(eLogs, os.Stderr)
if the logFile input is ioutil.Discard
? The intent is pretty clear that any log data can be thrown away, and this would have a minimum impact on users relying on the existing API.
from logger.
I think reset writers can solve this problem and doesn't influence existing users:
func (l *Logger) SetOutput(writers ...io.Writer){
logLock.Lock()
defer logLock.Unlock()
l.infoLog.SetOutput(io.MultiWriter(writers...))
l.warningLog.SetOutput(io.MultiWriter(writers...))
l.errorLog.SetOutput(io.MultiWriter(writers...))
l.fatalLog.SetOutput(io.MultiWriter(writers...))
}
from logger.
Related Issues (14)
- Allow setting log depth
- Allow setting log flags
- custom logger format output HOT 1
- Add Semver.
- undefined: setup HOT 5
- Not working inside docker image HOT 4
- Multiple output files doesn't use the correct "SetFlags"
- I want write log Info, log error. I don't want write log debug. What should I do?
- File already be closed
- Very minor typo in comment.
- Support for Windows EventIDs
- undefined: setup for GOARCH=wasm GOOS=js
- Fatal/Fatalf won't allow final log flush
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from logger.