Git Product home page Git Product logo

Comments (4)

gmassman avatar gmassman commented on May 8, 2024

I'm getting the same behavior.
In my tests I set up logger like so testLogger := logger.Init("Test", false, false, ioutil.Discard), but still ERROR messages go to stdout. I wouldn't mind working on this if someone from the core team gave me some guidance on how to proceed.

EDIT:
After a little digging, I believe logger.go#L97 is causing the issue. This could be resolved by moving the line inside the if verbose {...}, or adding an option for skipping the eLogs = append(eLogs, os.Stderr).

from logger.

adjackura avatar adjackura commented on May 8, 2024

There's not a simple way to get this functionality and keep the API surface for existing users. In our other loggers we moved to options so we could add features like this, but that would be a breaking change here. We could add options on top of the existing arguments to Init though, right now 'stdout' would be the only option.

from logger.

gmassman avatar gmassman commented on May 8, 2024

Would it be safe to skip eLogs = append(eLogs, os.Stderr) if the logFile input is ioutil.Discard? The intent is pretty clear that any log data can be thrown away, and this would have a minimum impact on users relying on the existing API.

from logger.

dozysun avatar dozysun commented on May 8, 2024

I think reset writers can solve this problem and doesn't influence existing users:

func (l *Logger) SetOutput(writers ...io.Writer){    
     logLock.Lock()    
     defer logLock.Unlock()
     l.infoLog.SetOutput(io.MultiWriter(writers...))
     l.warningLog.SetOutput(io.MultiWriter(writers...))
     l.errorLog.SetOutput(io.MultiWriter(writers...))
     l.fatalLog.SetOutput(io.MultiWriter(writers...))
}

from logger.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.