Consider adding `/scannerlib/proto` as part of source control about localtoast HOT 6 CLOSED

Hi, sorry for the late reply

The problem is that the files we import from grafeas and the ones under /scannerlib/proto are .proto files that have to be compiled with protoc into .pb.go files before we can link them against the rest of the source code.

The only way we can know about the files in advance is if we kept a precompiled .pb.go file for each .proto file around in the source, which we'd have to remember to update whenever we make changes to the .protos, so it'd add some complexity to the codebase.

from localtoast.

Hi @erikvarga - any update on this or consideration here?

from localtoast.

Though while I don't see a good way to fix the go mod tidy issue, moving the grafeas deps into a git submodule would fix the non-networked env issue, so that could be a feature for us to consider.

from localtoast.

moving the grafeas deps into a git submodule would fix the non-networked env issue

Hm, except github doesn't allow releases that include submodules, which would make it not possible for people to just download the released .zip and build Localtoast from that :/

from localtoast.

Thanks for getting back to me on this!

download the released .zip and build Localtoast from that

That's exactly what I'd like to do (and since the environment this may be compiled on won't have a network, it'd be ideal to have all dependencies right there)

Have you considered dropping compiled binaries into releases? That could be a good first step

from localtoast.

Yeah, I think it should be possible for us to just add compiled binaries to our release

I added a compiled x86-64 binary and the config files to the latest release.

from localtoast.