add checks for clang-tidy and clang-format about llvm-premerge-checks HOT 5 CLOSED

@ChristianKuehnel currently this reports look like: https://reviews.llvm.org/D71594

from llvm-premerge-checks.

Recommended way to check for clang-format fixes is git clang-format https://llvm.org/docs/GettingStarted.html#sending-patches

if it's not installed we can run clang/tools/clang-format/git-clang-format --diff in a directory with applied patch

from llvm-premerge-checks.

to run clang-tidy:

git diff -U0 | clang-tidy-diff-8.py -p1 -clang-tidy-binary=clang-tidy-8

should do the trick given that we linked compile-commands.json and the sources in question were involved in compile commands (looks like we have to enable other projects in cmake to make sure that we will compile diff).

from llvm-premerge-checks.

Phabricator supports displaying "lint results" (section Lint results):
https://secure.phabricator.com/conduit/method/harbormaster.sendmessage/

I have no idea what the results looks like or on how to convert the clang-tidy output to this format.

If you want to give it a shot, you can extend/rewrite/duplicate/... the script:
https://github.com/google/llvm-premerge-checks/blob/master/scripts/phabtalk/phabtalk.py

Right now the script is a quick hack to report the test results and add a comment with a short summary. This is what I needed for the compile & test scenarios.

from llvm-premerge-checks.

Windows build will be addressed separately.

from llvm-premerge-checks.