Vector serialization crashing on MSVC 19.20.27508.1 for x64 about libnop HOT 2 CLOSED

Thanks for your patience getting back to you.

While libnop doesn't explicitly support MSVC, I think this issue should be fixable.

It seems that MSVC does bounds checking on operator[] in debug builds, even though the standard specifies that bounds checking is not performed. Computing an address one past the end of an array is standards compliant, so MSVC is technically incorrect here.

That being said, we can work around this with a simple change to: https://github.com/google/libnop/blob/master/include/nop/base/vector.h#L146

Replacing that line with this should do the trick:

return writer->Write(value.data(), value.data() + length);

A similar change is necessary here: https://github.com/google/libnop/blob/master/include/nop/base/vector.h#L169

return reader->Read(value->data(), value->data() + length);

If you would like to verify these changes in your local environment, I'm happy to take a pull request.

from libnop.

Fixed on master.

Cheers

from libnop.