Does not compile with Sun Studio 12 about leveldb HOT 8 CLOSED

Comment #1 originally posted by [email protected] on 2011-07-06T14:03:40.000Z:

This stuff is required because the Solaris libCrun/libCstd is incompatible with the g++ runtime. So, if we're linking leveldb into an app with other libraries built against Solaris C++ runtimes, we're out-of-luck.

Here's a patch that fixes it. Passes all tests on Solaris and still works on Linux in my tests.

Enjoy. Please consider applying this, because we have to maintain this nasty diff to build.

from leveldb.

Comment #2 originally posted by [email protected] on 2011-07-14T23:42:50.000Z:

Before we patch in your change, could you fill out Google's Contributor Agreement? You can do this online:
http://code.google.com/legal/individual-cla-v1.0.html
Let me know when you have done so.

A few question:
Do all tests still pass after this change?
Why do you remove the "," at the end of enums? Is that something Sun Studio does not like?
Why does util/comparator require #include ?
In table.h, is there no library function to reverse a string? The rev.append() way of doing things seems expensive/hacky.

Thanks for your help!

Gabor Cselle
Product Managr, Google

from leveldb.

Comment #3 originally posted by [email protected] on 2011-07-15T00:27:49.000Z:

Do all tests still pass after this change?

Yes they do.

Why do you remove the "," at the end of enums? Is that something Sun Studio does not like?

Sun Studio does not like them. I believe it isn't actually valid C++, but most C++ compilers are tolerant of the (rather convenient) offense.

Why does util/comparator require #include ?

std::min and std::max are in under Sun Studio's C++ SDK.

In table.h, is there no library function to reverse a string? The rev.append() way of doing things seems expensive/hacky.

I could find none. As it was it didn't compile. That change is in table_test.cc (not table.h). So, the performance penalty doesn't enter the library in any way with this change.

from leveldb.

Comment #4 originally posted by [email protected] on 2011-07-15T00:28:37.000Z:

Signed ICLA as [email protected].

from leveldb.

Comment #5 originally posted by [email protected] on 2011-07-19T23:38:35.000Z:

This is now fixed in r38. Thanks for your help! If you have a chance, can you please verify the fix?

from leveldb.

Comment #6 originally posted by postwait on 2011-07-20T04:33:44.000Z:

almost perfect. Sun Studio doesn't define "asm" and "volatile", but instead just the normal keywords "asm" and "volatile". In your merge you consolidated the g++ and SUNPRO_CC stuff into one block using the volatile and asm keywords which cases a compile error.

My question is: doesn't g++ support the plain-old "asm" and "volatile" keywords so that we could consolidate to the same non-underscore version for both compiler suites?

By changing volatile to volatile and asm to asm on line 57 of port/atomic_pointer.h, all compiles, links and passes a make check using Sun Studio 12.1.

from leveldb.

Comment #7 originally posted by [email protected] on 2011-07-21T02:42:49.000Z:

This should now be fixed in Revision 39:.

Can you check again?

Thanks for your help! Gabor

from leveldb.

Comment #8 originally posted by [email protected] on 2011-07-21T03:18:52.000Z:

Victory. All is well on the Sun Studio front.

from leveldb.