Comments (6)
KSName is meant to align with qualified names therefore you are seeing this result, but it is also reasonable to provide correct logic to get the qualifier. We will discuss to see what's the path forward for KSName.
The Glide example is not using KotlinPoet in a very practical way, mainly due to there is no KSP support built in KotlinPoet so we took a workaround to address the ClassName, ideally, there should be some extension functions around KSP properties to work with KotlinPoet.
from ksp.
sounds good. I'm one of the maintainers of KotlinPoet, we'd be interested in seeing what a kotlinpoet-ksp artifact could like on our end. Some obvious ones come to mind, like FileSpec.writeTo(CodeGenerator) support and KSName.toClassName(). Open to other suggestions as well for things you'd want to see in an artifact like that, let us know 👍. Will file an issue on our end soon to track ideas
from ksp.
Current KSName implementation is based on the qualified name spec.
To address this issue I will add a new property/function to KSName.
from ksp.
A KSName
returned by compiler/KSP is guaranteed to be unambiguous. As for getQualifier
, did you mean to get its package name? If so, KSDeclaration.getPackage
(to be added) might serve the purpose.
Forcing the notion of package in KSName would require all creation sites to supply package and the remaining identifier(s) separately. Although I agree that specifying package explicitly is much clearer, it is also less convenient.
As for the /
separator, it looks like an encoding / implementation choice of Kotlin metadata. Would getPackage
be more human friendly?
from ksp.
To add more context, on Kotlin language perspective names are separated by dot, and the case when you see names separated by slash is platform dependent (in this case, it is the JVM runtime name). In my opinion the right way to solve this is to provide KSDeclaration with a getPackage
API so that you can inspect package name for a nested class. However, you will have to make some adjustments to the KotlinPoet code you linked with this approach.
from ksp.
Alternative solution for this is shipped with android/kotlin#98
from ksp.
Related Issues (20)
- [KSP2] KSAnnotations with annotation properties with a default value always resolve to null HOT 1
- ksp configurations do not resolve versions from gradle platform
- [KSP2] Kotlin `Function*` types reports inconsistent package and qualified names
- [KSP2] Intersection types are not modeled
- Typealias annotation parameters are resolved as "alias target", not the type alias itself
- [Help Wanted] Cannot get build directory using codegenerator
- Stack overflow when resolving the type of typealias + cycles
- [KSP2] Modifier.FUN is missing in functional interfaces
- KSP2: KtInvalidLifetimeOwnerAccessException: Access to invalid KtAlwaysAccessibleLifetimeToken: PSI has changed since creation
- [ksp] [Hilt] Cannot update Dagger/Hilt to 2.49
- [KSP2] Nullable type arg type becomes non-null after replace() call
- [KSP2] Modifiers are missing for property accessors
- [KSP2] Couldn't find type parameter bounds of functions
- [KSP2] Resolver.mapToJvmSignature doesn't unwrap inline classes
- KSP2: Model enum entries in annotation values
- [KSP2] Type annotations are sometimes missing on type variable bounds in Java
- [KSP2] Property setter parameter name becomes `value` HOT 2
- [feature request] Retrieve property default value for compile time constants
- Java native modifier is missing
- NoSuchMethodError with Kotlin 1.9.24
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ksp.