Git Product home page Git Product logo

Comments (11)

neetopia avatar neetopia commented on May 8, 2024 1

fixed in #528

from ksp.

neetopia avatar neetopia commented on May 8, 2024

android/kotlin#60 contains a partial fix. With that commit you will be able to see the name of the missing argument, but not able to find out the default value of that argument. Still working to find a solution to find the default value.

from ksp.

yigit avatar yigit commented on May 8, 2024

i think this bug might already be fixed?
https://android-review.googlesource.com/c/platform/frameworks/support/+/1513790 is passing.

from ksp.

yigit avatar yigit commented on May 8, 2024

actually nevermind, looks like it is still broken for defaults values w/ other annotations.

from ksp.

neetopia avatar neetopia commented on May 8, 2024

Yes, it is broken for annotations declared in kotlin and then compiled.

from ksp.

yigit avatar yigit commented on May 8, 2024

Unfortunateely this still looks broken in beta07.
To reproduce, you can enable this line in the test in AndroidX

from ksp.

neetopia avatar neetopia commented on May 8, 2024

fixed in #591

from ksp.

elihart avatar elihart commented on May 8, 2024

I think I ran into an edge case in 1.0 where, even with this fix, I get a null default value in the case where a class is defined within the annotation class.

Happens with both kotlin and java - here is a kotlin example.

annotation class Example(
    val classParam: KClass<*> = DEFAULT::class
) {
    object DEFAULT
}

Moving the object outside the annotation class fixes the problem

from ksp.

neetopia avatar neetopia commented on May 8, 2024

is the above class from a compiled library?

from ksp.

elihart avatar elihart commented on May 8, 2024

Yes, the annotation class is defined in a compiled library.

from ksp.

neetopia avatar neetopia commented on May 8, 2024

thanks, I'll create a separate issue to track.

from ksp.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.