Git Product home page Git Product logo

Comments (7)

melver avatar melver commented on May 18, 2024

If possible, it might be good to get results for both x86 + arm64 (using the current implementation that doesn't have a static pool).

For deciding if we need to further optimize arm64, we actually need arm64. It would be good to have this ready at the latest when people start commenting on the arm64 version.

from kernel-sanitizers.

ramosian-glider avatar ramosian-glider commented on May 18, 2024

I don't think we strictly need arm64 benchmarks for the RFC.
My gut feeling is that implementing a static pool on ARM is both doable and worth it wrt performance, so we just need an arch/arm64 expert to look at the code.

from kernel-sanitizers.

melver avatar melver commented on May 18, 2024

I don't think we strictly need arm64 benchmarks for the RFC.

Yes, I should have clarified that it's not a dependency.

My gut feeling is that implementing a static pool on ARM is both doable and worth it wrt performance, so we just need an arch/arm64 expert to look at the code.

That's reasonable. Here's hoping it is simple enough to do. :-)

from kernel-sanitizers.

ramosian-glider avatar ramosian-glider commented on May 18, 2024

Some benchmark data from running hackbench -s 4096 -l 500 -f 25 30 times (3 series of 1 preheat run + 10 benchmark runs with reboots between series):

sample_interval slowdown, % error (±%)
10 1.2 0.4
100 0.4 0.2
1000 0.8 0.7
10000 0.9 0.4
100000 0.5 0.3

This is an x86 QEMU with 1 CPU.

from kernel-sanitizers.

ramosian-glider avatar ramosian-glider commented on May 18, 2024

The benchmark is quite noisy, maybe running under taskset will be more helpful.

from kernel-sanitizers.

ramosian-glider avatar ramosian-glider commented on May 18, 2024

Please disregard the above data, it was measured with KASAN enabled.
Without KASAN the slowdown is within the noise level for sample_interval values within [10,100000]

from kernel-sanitizers.

melver avatar melver commented on May 18, 2024

RFC was sent, and at least for x86 we know where we're at. Let's close this for now.

from kernel-sanitizers.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.