Git Product home page Git Product logo

Comments (4)

mgol avatar mgol commented on May 6, 2024

BTW, if there's any other way to detect the Playwright-provided WebKit in runtime, that would help as well, even without a UA override.

from karma-webkit-launcher.

MarkusBordihn avatar MarkusBordihn commented on May 6, 2024

Thanks for the feedback, I will take a closer look into this in the next days.

The current version of Playwright uses a shell script to launch the headless browser like mentioned in #1.
For this reason it's isolated and there is no easy way to overwrite the UA.

But let me check, if I could integrate something over the karma tester itself.

from karma-webkit-launcher.

MarkusBordihn avatar MarkusBordihn commented on May 6, 2024

I just added a easy possible to check if Playwright is used during the tests.

See: https://github.com/google/karma-webkit-launcher#detected-if-safari-or-playwright-is-used

from karma-webkit-launcher.

mgol avatar mgol commented on May 6, 2024

@MarkusBordihn Thanks. While testing the change, I found two issues (one being a regression), PTAL: #4 & #5.

from karma-webkit-launcher.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.