Git Product home page Git Product logo

Comments (1)

richkadel avatar richkadel commented on May 5, 2024

Thanks for the suggestion! I'm sure it's possible to use something like nom or pest to support the parsing, but the reason I didn't start with this approach was twofold:

  • I found there were subtle complexities to preserving certain structure and format characteristics, such as preserving indent within a comment block, and I found it easier to reason about the content by interacting with the token space at a lower level. To do the same with a higher-level parser library can sometimes be at least as hard if not harder.
  • The json5 syntax is fairly trivial and I have extensive experience using Regex. I am not too concerned about the maintainability here. I'm not sure if there will ever be a need to make changes to this grammar. (Never say never, though.)

A change like this is pretty major, and I don't think you are suggesting the result will provide any new capability. Given the current implementation works (and is well tested as you point out), I think it's safer to leave this as-is.

Let me know if you have other thoughts.

Thanks for reviewing!

from json5format.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.