Git Product home page Git Product logo

Comments (5)

patrick-kidger avatar patrick-kidger commented on July 28, 2024 1

So jaxtyped actually happens to return a class instance, rather than a function. That's the immediate reason for what we're observing here.

For your downstream use-case with torch.compile, can you check whether:

  • Whether

    @typechecker
    def forward(...)

    works?

  • And whether

    def wrapper(fn):
        @functools.wraps(fn)
        def wrapped(*args, **kwargs):
            return jaxtyped(typechecker(fn))(*args, **kwargs)
        return wrapped
    
    class Model(nn.Module):
        @wrapper
        def forward(...): ...

    works?

That'll give some insight on how we might fix this.

from jaxtyping.

PaulScemama avatar PaulScemama commented on July 28, 2024

They both work.

from jaxtyping.

patrick-kidger avatar patrick-kidger commented on July 28, 2024

Great. Can you try install from the no-more-jaxtyped branch (c.f. #72) and see if this works for your downstream use-case? If so then I'll merge that PR.

from jaxtyping.

st-- avatar st-- commented on July 28, 2024

I had just come across what is probably the same issue in different clothes when trying to subclass tensorflow_probability's Distribution type - that also got resolved by #72!

from jaxtyping.

patrick-kidger avatar patrick-kidger commented on July 28, 2024

Closing as I think this issue is resolved.

from jaxtyping.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.