Git Product home page Git Product logo

Comments (2)

mblondel avatar mblondel commented on May 5, 2024 2

Thanks Robert! The issue comes from the fact that jnp.vdot doesn't work between scalars. So this would be another fix:

import functools

_vdot = functools.partial(jnp.vdot, precision=jax.lax.Precision.HIGHEST)

def _vdot_safe(a, b):
  return _vdot(jnp.asarray(a), jnp.asarray(b))

def tree_vdot(tree_x, tree_y):
  """Compute the inner product <tree_x, tree_y>."""
  vdots = tu.tree_multimap(_vdot_safe, tree_x, tree_y)
  return tu.tree_reduce(operator.add, vdots)

CC @shoyer @froystig

from jaxopt.

gowerrobert avatar gowerrobert commented on May 5, 2024

Nice solution! I timed the two solutions here in colab.

They are pretty much as fast as eachother. So I'd recommend the one you prefer for maintenance/elegance.

from jaxopt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.