Push registration: use propel lib about ioweb2016 HOT 8 CLOSED

Phase 3 right?

from ioweb2016.

As well as #104 I/we also need to do a review of the UI pieces.

The text next to the checkbox last year did not match the behaviour, so that probably needs updating.

Also, Firebase allows us to have real-time updates, so the UI should respond to those.

from ioweb2016.

The schedule page will be very different this year. We'll definitely need
your help making the toasts work well with firebase.

On Fri, Feb 19, 2016, 5:26 AM Mat Scales [email protected] wrote:

As well as #104 #104 I/we
also need to do a review of the UI pieces.

The text next to the checkbox last year did not match the behaviour, so
that probably needs updating.

Also, Firebase allows us to have real-time updates, so the UI should
respond to those.

—
Reply to this email directly or view it on GitHub
#103 (comment)
.

from ioweb2016.

Has this been fixed by #104 ? If not could we add more background about what that bug is?

from ioweb2016.

What's this bug? Is it to use Propel?

from ioweb2016.

Yes, it is to use Propel. PR incoming soon, but I'm working through the UX of how we interact with Firebase.

Here are the notes I'm using to work this out, for future reference.

Possible bad behaviour that we need to guard against:

• List of subscriptions in FB grows indefinitely
• Checkbox starts as 'off' on page load, which causes unsubscribe every time for all clients
• Toggling checkbox to 'on' while offline disables the button forever (doesn't recover when coming back onlione)
• Other client toggles on, this client prompts for permission
• Cannot subscribe when offline
• Toggle can be on when there is actually no subscription

There are three things that have state - the local subscription, the checkbox, and Firebase.

When local subscription changes from 'off' to 'on':

• Set checkbox to on
• Set checkbox to enabled
• Set FB to on

When local subscription changes from 'off' to 'error':

• Set checkbox to off
• Set checkbox to enabled
• Show a message
• Leave FB as is

When local subscription changes from 'on' to 'off':

• Set checkbox to off
• Set checkbox to enabled
• Set FB to off
• Remove existing subscription from FB

When FB changes from 'on' to 'off':

• If local subscription, show message saying you were remotely unsubscribed?
• Unsubscribe
• Set checkbox to off
• Set checkbox to enabled

When FB changes from 'off' to 'on':

• Leave local subscription as is
• Leave checkbox as is

When checkbox is clicked while off

• Subscribe
• Disable checkbox
• (checkbox should animate while disabled)

When checkbox is clicked while disabled

• Do nothing

When checkbox is clicked while on

• Unsubscribe
• Disable checkbox
• (checkbox should animate while disabled)

from ioweb2016.

Should we also cache the checkbox state for offline?

Yea, I think the easiest is to always disable the checkbox if you're offline since there's no way for the user to make that change. Pretty sure we did that last year instead of worrying about the offline -> online case.

from ioweb2016.

@ebidel the state of the checkbox should be based on whether we have a local subscription. This can be initially checked offline anyway.

from ioweb2016.