Comments (4)
martindemello
commented on April 28, 2024
this seems to be a complicated bug. the underlying issue is that this line
importlib.util.find_spec("tf2jax._src.config")
throws an exception (not sure why, it works from ipython). that makes us think that the import is tf2jax._src.__init__ (i.e. a package import of _src rather than a module import of _src.config). before #63 we would then try falling back to just mechanically converting the relative module fullname to a filepath, which caused some issues with package imports. fixing that now filters out tf2jax._src.config altogether, but #63 fixed some more serious bugs so we can't revert it.
from importlab.
shaobohou
commented on April 28, 2024
That sounds like a bug, no?
It fails to resolve tf2jax._src.config from ops.py, but it succeeds for tf2jax.py in the same directory, except not for the direct import but for the one imported originally in ops.py
+ tf2jax/_src/tf2jax.py
:: collections/__init__.py
:: inspect.py
:: typing.py
:: absl/logging/__init__.py
:: jax/__init__.py
:: jax/numpy/__init__.py
:: numpy/__init__.py
:: tensorflow/__init__.py
:: tf2jax/_src/__init__.py
tf2jax/_src/ops.py
:: dataclasses.py
:: functools.py
:: jax/_src/lax/control_flow/__init__.py
tf2jax/_src/config.py
:: contextlib.py
tf2jax/_src/numpy_compat.py
tf2jax/_src/xla_utils.py
tf2jax/_src/utils.py
:: tree/__init__.py
:: tensorflow/python/framework/op_def_registry.py
:: tensorflow/python/framework/ops.py
Changing the import to import tf2jax._src.config as config also works, but feels like we shouldn't have to do this.
from importlab.
martindemello
commented on April 28, 2024
yes, it's definitely a bug, i just can't pinpoint why it occurs. this is the traceback from importlib, and as noted above i cannot reproduce it by trying to run importlib.util.find_spec from a separate program or ipython:
Exception finding spec for tf2jax._src.config
Module 'numpy.core' has no attribute 'numerictypes'
Traceback (most recent call last):
File "/usr/local/google/home/mdemello/github/importlab/importlab/import_finder.py", line 102, in _resolve_import_versioned
spec = importlib.util.find_spec(name)
File "/usr/local/google/home/mdemello/.asdf/installs/python/3.10.4/lib/python3.10/importlib/util.py", line 94, in find_spec
parent = __import__(parent_name, fromlist=['__path__'])
File "/usr/local/google/home/mdemello/github/tf2jax/tf2jax/__init__.py", line 21, in <module>
from tf2jax._src.tf2jax import AnnotatedFunction
File "/usr/local/google/home/mdemello/github/tf2jax/tf2jax/_src/tf2jax.py", line 27, in <module>
import tensorflow as tf
File "/usr/local/google/home/mdemello/.asdf/installs/python/3.10.4/lib/python3.10/site-packages/tensorflow/__init__.py", line 37, in <module>
from tensorflow.python.tools import module_util as _module_util
File "/usr/local/google/home/mdemello/.asdf/installs/python/3.10.4/lib/python3.10/site-packages/tensorflow/python/__init__.py", line 42, in <module>
from tensorflow.python import data
File "/usr/local/google/home/mdemello/.asdf/installs/python/3.10.4/lib/python3.10/site-packages/tensorflow/python/data/__init__.py", line 21, in <module>
from tensorflow.python.data import experimental
File "/usr/local/google/home/mdemello/.asdf/installs/python/3.10.4/lib/python3.10/site-packages/tensorflow/python/data/experimental/__init__.py", line 96, in <module>
from tensorflow.python.data.experimental import service
File "/usr/local/google/home/mdemello/.asdf/installs/python/3.10.4/lib/python3.10/site-packages/tensorflow/python/data/experimental/service/__init__.py", line 419, in <module>
from tensorflow.python.data.experimental.ops.data_service_ops import distribute
File "/usr/local/google/home/mdemello/.asdf/installs/python/3.10.4/lib/python3.10/site-packages/tensorflow/python/data/experimental/ops/data_service_ops.py", line 24, in <module>
from tensorflow.python.data.experimental.ops import compression_ops
File "/usr/local/google/home/mdemello/.asdf/installs/python/3.10.4/lib/python3.10/site-packages/tensorflow/python/data/experimental/ops/compression_ops.py", line 16, in <module>
from tensorflow.python.data.util import structure
File "/usr/local/google/home/mdemello/.asdf/installs/python/3.10.4/lib/python3.10/site-packages/tensorflow/python/data/util/structure.py", line 30, in <module>
from tensorflow.python.ops import tensor_array_ops
File "/usr/local/google/home/mdemello/.asdf/installs/python/3.10.4/lib/python3.10/site-packages/tensorflow/python/ops/tensor_array_ops.py", line 34, in <module>
from tensorflow.python.ops import array_ops
File "/usr/local/google/home/mdemello/.asdf/installs/python/3.10.4/lib/python3.10/site-packages/tensorflow/python/ops/array_ops.py", line 1564, in <module>
_NON_AUTOPACKABLE_TYPES = set(np.core.numerictypes.ScalarType)
File "/usr/local/google/home/mdemello/.asdf/installs/python/3.10.4/lib/python3.10/site-packages/numpy/core/__init__.py", line 161, in __getattr__
raise AttributeError(f"Module {__name__!r} has no attribute {name!r}")
AttributeError: Module 'numpy.core' has no attribute 'numerictypes'
from importlab.
shaobohou
commented on April 28, 2024
Thanks for looking into it!
For the moment, I have downgraded importlab (and pytype) in my setup, so it is not urgent.
from importlab.
Related Issues (20)
- Importlab doesn't work when passed a directory.
- importlab interacts badly with `pyenv local` HOT 4
- Crash when analyzing files of different Python versions
- importlab crashes on file with tensorflow import HOT 6
- Incorrect inferred module name for __init__.py files
- Name clash between input file and system file leads to incorrect dependency tree. HOT 1
- Can't find pip-installed google-auth in Python 2
- pyenv breaks unittests
- Improve the default value of the --python-version option HOT 5
- use strongly connected component detection in the graph builder HOT 2
- Don't require .py extension
- module recorded as "unreadable" when one of its direct dependencies is unloadable
- Tags are not up to date with pypi HOT 1
- Include tests in sdist
- port the ninja file generator from pytype
- Command-line tool needs extension? HOT 1
- Add --version to bin importlab for auto generate man page via help2man
- Run tests via python > 3.0 failed HOT 4
- Importlab should not execute the code it analyzes
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from importlab.