GNU makefiles are usually expected to have 'install' target. It is expected to install

This patch fixes this issue: <div class="highlight highlight-source-diff notransla

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

You should change <div class="snippet-clipboard-content notranslate position-relat

Actually I need to override the PREFIX and <code clas

Please create an 'install' target about highwayhash HOT 5 CLOSED

google commented on May 5, 2024

Please create an 'install' target

from highwayhash.

Comments (5)

cdluminate commented on May 5, 2024 2

This patch fixes this issue:

diff --git a/Makefile b/Makefile
index c0e6be5..f5e62a1 100644
--- a/Makefile
+++ b/Makefile
@@ -8,6 +8,10 @@ ifeq ($(OSTYPE),FreeBSD)
 override CXXFLAGS +=-fPIC
 endif

+PREFIX ?= /usr/local
+INCDIR ?= $(PREFIX)/include
+LIBDIR ?= $(PREFIX)/lib
+
 SIP_OBJS := $(addprefix obj/, \
        sip_hash.o \
        sip_tree_hash.o \
@@ -99,4 +103,10 @@ distclean: clean
        [ ! -d bin ] || $(RM) -r -- bin/
        [ ! -d lib ] || $(RM) -r -- lib/

+install: lib/libhighwayhash.a
+       mkdir -p $(DESTDIR)/$(LIBDIR)
+       mkdir -p $(DESTDIR)/$(INCDIR)/highwayhash
+       install -m0755 lib/libhighwayhash.a $(DESTDIR)/$(LIBDIR)
+       install -m0755 highwayhash/*.h $(DESTDIR)/$(INCDIR)/highwayhash/
+
 .PHONY: clean distclean all

from highwayhash.

jan-wassenberg commented on May 5, 2024

@yurivict , thanks for the suggestion, and @cdluminate , thank you kindly for the patch.
I don't have much experience in this area but it looks good. Probably helpful to also add install to .PHONY? I'll merge these changes today.

from highwayhash.

cdluminate commented on May 5, 2024

The install target is added to PHONY in the pull request.

from highwayhash.

yurivict commented on May 5, 2024

You should change

INCDIR ?= $(PREFIX)/include
LIBDIR ?= $(PREFIX)/lib

INCDIR := $(PREFIX)/include
LIBDIR := $(PREFIX)/lib

LIBDIR happens to be predefined in FreeBSD during the port build. There should be no need to allow INCDIR and LIBDIR to be predefined in the Makefile.

Thank you!

from highwayhash.

cdluminate commented on May 5, 2024

Actually I need to override the PREFIX and LIBDIR in Debian packaging script, so files can be installed to the correct place. See https://github.com/CDLuminate/debian-highwayhash/blob/master/debian/rules#L5-L6

from highwayhash.

Recommend Projects