Git Product home page Git Product logo

Comments (5)

eustas avatar eustas commented on May 9, 2024

Moreover:

  1. Root project can not use the snippets given by googletest - cmake will complain that gtest library already exists (added in HWY)
  2. If HWY is included with EXCLUDE_FROM_ALL option, then HWY tests fail (as those are not built)

Perhaps configuration should be different, for HWY as a root project and as library (added via add_subdirectory).

from highway.

jan-wassenberg avatar jan-wassenberg commented on May 9, 2024

@eustas is the biggest pain point that you want to do something with gTest in JXL, but Hwy's adding of gTest prevents that?
Does HWY_SYSTEM_GTEST help?

I'm open to suggestions on what we should do/improve.

from highway.

eustas avatar eustas commented on May 9, 2024

HWY_SYSTEM_GTEST results in "Could NOT find GTest (missing: GTEST_INCLUDE_DIR GTEST_MAIN_LIBRARY)".
I'll prepare PR / CL with a variant of fix.

from highway.

jan-wassenberg avatar jan-wassenberg commented on May 9, 2024

Yes, we might need to set GTEST_ROOT when building for that to work: https://stackoverflow.com/questions/17469843/cmake-cannot-find-a-required-library

I'll prepare PR / CL with a variant of fix.

Sounds good!

from highway.

eustas avatar eustas commented on May 9, 2024

Resolved by not adding test targets when project is used as library.

from highway.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.