math: use types defined in image repository about gxui HOT 9 OPEN

👍 to the idea.

If possible, I'd like to see github.com/go-gl/mathgl/mgl32 used too. Are there valid reasons why it isn't?

from gxui.

@crawshaw is there any reason why the methods couldn't be absorbed into https://godoc.org/golang.org/x/image/math/f32? It's not going to break compatibility.

from gxui.

argh, wrong button

from gxui.

But then again, it's a bit weird to have that sort of math in an image library.

from gxui.

Methods can be added to image/math if we can reach consensus on what they should be. We had a lot of trouble with it in early discussions. We could find common ground on types, so we started there.

from gxui.

If the methods cannot be brought across, I don't really see the gain in switching to the f32 package - does it not contain just 7 typedefs? Do you see common functionality between GXUI and f32?

from gxui.

Let's punt on this issue for a bit, I believe it will be useful but would like to demonstrate it with code.

It is also worth looking at https://godoc.org/github.com/go-gl/mathgl/mgl32 as@shurcooL mentioned, it has a lot of relevant machinery in it.

from gxui.

Yup mgl32 looks like a pretty good replacement. It doesn't have my fantastic unicode art though. :)

from gxui.

Yup mgl32 looks like a pretty good replacement. It doesn't have my fantastic unicode art though. :)

Please feel free to make a PR, improvements to it are always welcome.

from gxui.