Git Product home page Git Product logo

Comments (5)

ben-clayton avatar ben-clayton commented on May 3, 2024

Hi mattn,
Blimey, that was quick - GXUI has only been public for about about 18 hours. I was hoping for a quiet launch so I had time to tidy the source. :)

The COMPILE_STATUS test looks like the correct solution. Is this enough to fix your problem?
It appears you have signed Google's Contribution License Agreement. Is this correct?

from gxui.

mattn avatar mattn commented on May 3, 2024

The COMPILE_STATUS test looks like the correct solution. Is this enough to fix your problem?

COMPILE_STATUS doesn't work well for this case. Because even though COMPILE_STATSUS become GL_FALSE, the log returns No errors.. So checking COMPILE_STATUS is not good for me.
About my commits in above, since first commit is wrong, I forcely pushed second commit. So if you click merge button, the second one will be merged. Please notice.

It appears you have signed Google's Contribution License Agreement. Is this correct?

Yes, I had already signed CLA for golang/go.

from gxui.

ben-clayton avatar ben-clayton commented on May 3, 2024

Because even though COMPILE_STATSUS become GL_FALSE, the log returns No errors.

Right - I think the problem is that you're checking COMPILE_STATUS for both the shader and the program.
You probably want:

s.Compile()
if s.Get(gl.COMPILE_STATUS) != gl.TRUE {
    panic(s.GetInfoLog())
}

and:

program.Link()
program.Validate()
if program.Get(gl.LINK_STATUS) != gl.TRUE {
    panic(program.GetInfoLog())
}

Do you mind seeing if making these changes fixes your issue?

Yes, I had already signed CLA for golang/go.

Great.

from gxui.

mattn avatar mattn commented on May 3, 2024

done. please take a look.

from gxui.

mattn avatar mattn commented on May 3, 2024

Ah, it's better to be PR.

from gxui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.