Comments (7)
Hiding the view immediately is important because the server typically displays
some inappropriate instructions for the user once sign-in has completed.
I'm not sure which flow you are saying is ugly. Dismissal of the view
controller without completing sign-in will not go through the popView method.
Original comment by [email protected]
on 7 Aug 2012 at 6:07
from gtm-oauth2.
Dismissal after signed-in is ugly.
Original comment by [email protected]
on 7 Aug 2012 at 3:42
from gtm-oauth2.
When the user has signed in, the server will display an html message asking the
user to copy an auth token. In the context of the sign-in controller, this
messages does not make sense for the user, so the controller is trying to hide
the message as quickly as possible.
Original comment by [email protected]
on 7 Aug 2012 at 5:01
from gtm-oauth2.
Then I think we can let the web view to show a more user friendly message such
as "You've Signed In Successfully", instead of hiding the whole view.
Try presenting and dismissing GTMOAuth2ViewControllerTouch as a model view,
you'll see it is really ugly to hide the view before the dismissing animation
completes.
Original comment by [email protected]
on 7 Aug 2012 at 5:13
from gtm-oauth2.
We do not have control over what text the server displays in the html following
sign-in.
Original comment by [email protected]
on 7 Aug 2012 at 11:25
from gtm-oauth2.
No but you have absolute control over what the webview shows up.
Original comment by [email protected]
on 20 Apr 2013 at 3:53
from gtm-oauth2.
@grobb...
> Hiding the view immediately is important because the server typically
displays some inappropriate instructions for the user once sign-in has
completed.
Yes WebView displays "please copy this code..."
But you may hide ONLY web view and show some kind of UIViewActivityIndicator
Also it will be useful because signIn process is not finished by that point
authCode obtained but it is not exchanged with token. Authentification process
still continue end may fail.
But at this point view is hide instantly and also popViewBlock(); is called.
So i have ugly dismissed controller without animation (i present it moddaly)
And after that, in viewWillAppear of presentingViewController I can't use auth
because [auth canAutorize] == NO
> I'm not sure which flow you are saying is ugly. Dismissal of the view
controller without completing sign-in will not go through the popView method.
Yes when i dissmiss it manually, but it goes when authCodeObtained than
popViewBlock() is called
---
#1 in -[GTMOAuth2ViewControllerTouch popView] at
GTMOAuth2ViewControllerTouch.m:405
#2 in -[GTMOAuth2ViewControllerTouch signIn:displayRequest:] at
GTMOAuth2ViewControllerTouch.m:628
#3 in -[GTMOAuth2SignIn closeTheWindow] at GTMOAuth2SignIn.m:367
#4 in -[GTMOAuth2SignIn authCodeObtained] at GTMOAuth2SignIn.m:504
#5 in -[GTMOAuth2SignIn titleChanged:] at GTMOAuth2SignIn.m:458
#6 in -[GTMOAuth2ViewControllerTouch webViewDidFinishLoad:] at
GTMOAuth2ViewControllerTouch.m:832
---
Also can you remove @private from GTMOAuth2ViewControllerTouch ivars
this will allow to fix a lot in subclasses
Original comment by [email protected]
on 5 May 2015 at 6:34
from gtm-oauth2.
Related Issues (20)
- Plus.me scope is deprecated
- This is the last few lines of code on a different thread that I can see while I debug the issue. I've spent quite some time on debugging this now with no success and eventually decided to file this issue.
- GTMOAuth2Authentication.h file not found HOT 3
- "Don't ask for code again" for two factor auth is not working HOT 4
- Buttons in oauth2 controller not active
- canAuthorize returns false in simulator but true on real device (iOS 10) HOT 3
- default scopes added automatically? HOT 1
- Google calendar issues HOT 1
- Loss of authorisation on the simulator iPhone SE HOT 2
- Is this deprecated now? HOT 2
- GTMOAuth2ViewControllerTouch OAuth problem HOT 1
- 403. That's an error HOT 5
- Pod 1.1.4 - "GTMOAuth2ErrorTokenUnavailable" Naming error HOT 10
- Can't build Examples/OAuth2Sample HOT 2
- GTMOAuth2-iOS target copies Info.plist as a bundle resource. HOT 2
- Is GTMOAuth2WindowController something we can still use after the embedded webview deprecation? HOT 2
- authorizeFromKeychainForName: API calls fails in mac app extension. HOT 3
- My app crash when calling "GIDSignIn.sharedInstance().signIn()" at second run or another later HOT 5
- Error uploading file to Google Drive iOS with new Auth guideline HOT 1
- Warnings against Swift 4 HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gtm-oauth2.