Git Product home page Git Product logo

Comments (3)

trotterdylan avatar trotterdylan commented on April 27, 2024

That's weird, it's passing for me:

$ git log -n 1                                                                                                                                                              ─
commit 47e0e02297d6a43f8e9cb062e041802f93e4b09b
Author: Jurriaan Bremer <[email protected]>
Date:   Sat Jan 7 19:58:43 2017 +0100

    make strings with spaces easier to read (#64)
$ make build/runtime.pass
ok      grumpy  1.297s
runtime/grumpy PASS

And it looks like it's being run and passing on Travis: https://travis-ci.org/google/grumpy/builds/189841925#L252

from grumpy.

ns-cweber avatar ns-cweber commented on April 27, 2024

I was running go test ./runtime; running make build/runtime.pass succeeds. I take it go test isn't an approved testing mechanism? I tried reading through the Makefile, but I'm not make-literate yet.

from grumpy.

trotterdylan avatar trotterdylan commented on April 27, 2024

I debated the right way to set up the project and settled on using make rather than go build/test directly. The reason being that the standard libraries, tests, benchmarks, etc. require some setup to work properly. I settled on the build/ subdir being the GOPATH and runtime/*.go files are copied into build/src/grumpy.

That said it doesn't look like it'd be much work to get the runtime test suite working with go test, which would be convenient.

Either way, the README could help here by explaining the "official" way to run the test suite.

from grumpy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.