Git Product home page Git Product logo

Comments (3)

byohay avatar byohay commented on May 2, 2024

@petea what are your thoughts about this?

from googlesignin-ios.

petea avatar petea commented on May 2, 2024

GSI stores sign-in state in the default keychain group. If you have the Keychain Sharing capability enabled and one or more keychain access groups defined, the default keychain group will be the first item in this list of keychain access groups. Groups defined after this first group could be used for state sharing between apps without GSI state being present, if that's desired.

from googlesignin-ios.

byohay avatar byohay commented on May 2, 2024

@petea
In our apps the first keychain access group is the shared one, meaning GSI will store the state in a shared place that will be read and written by all our apps. That's undesired of course.
I can think of several ways to avoid such mistakes in the future:

  • Keep the current behavior and explicitly mention this in the README.
  • Use a different service for each app based on their bundle ID (Like being done in FB SDK). This will require migration which is not desired I assume.
  • Allow to select the keychain storage name (Like being done in MSAL). Might also require migration

What do you think?

from googlesignin-ios.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.