Update to 0.1.2 about google-api-cpp-client HOT 8 CLOSED

Hi @rcmaniac25 , I created a pull request for it:
#12

from google-api-cpp-client.

Thanks @snnn. Was this generated or did you hand-write the code? Because I had written some of the missing functionality for my fork, but I'm debating on merging yours in (as I think this repo is dead otherwise)

from google-api-cpp-client.

@rcmaniac25 I only did some minor changes in 5 files :

src/googleapis/client/service/service_request_pager.h
src/googleapis/client/service/test/service_request_pager_test.cc
src/googleapis/client/util/date_time.h
src/samples/calendar_sample_main.cc
src/samples/gdriveutil_main.cc

Because Google is doing a migration which replaces all mixed underscore/camelCase names (e.g. set_pageToken), which uniform underscored names (set_page_token). (ref: https://groups.google.com/forum/#!topic/google-api-cpp-client/0R3w9gvGOjY)

The others (service_apis/calendar && service_apis/drive) were downloaded from http://google.github.io/google-api-cpp-client/latest/available_service_apis.html

Please check it for me. Thanks.

from google-api-cpp-client.

Ok, I did something similar but I don't think I changed underscore/camelCase. I'll check it later, as I may merge your fork into mine because of the underscore change.

from google-api-cpp-client.

On Fri, Jan 2, 2015 at 2:32 AM, Changming Sun [email protected]
wrote:

@rcmaniac25 https://github.com/rcmaniac25 I only did some minor changes
in 5 files :

src/googleapis/client/service/service_request_pager.h
src/googleapis/client/service/test/service_request_pager_test.cc
src/googleapis/client/util/date_time.h
src/samples/calendar_sample_main.cc
src/samples/gdriveutil_main.cc

Because Google is doing a migration which replaces all mixed
underscore/camelCase names (e.g. set_pageToken), which uniform underscored
names (set_page_token). (ref:
https://groups.google.com/forum/#!topic/google-api-cpp-client/0R3w9gvGOjY)

​Yes. Underscores is our C++ style.​ The generated libraries might still be
generating method names in both formats, but that is going to stop soon.

The others (service_apis/calendar && service_apis/drive) were downloaded

from
http://google.github.io/google-api-cpp-client/latest/available_service_apis.html

​That is the best place to get current versions of an API. As APIs have
minor revisions, the new code shows up there automatically.
​

from google-api-cpp-client.

Ok, I ended up merging @snnn's changes for the underscore changes. I also saw that he did (smarter then my own) "typedef DateTime Date;" while I had originally implemented a Date class and essentially copied the content from DateTime to it.

from google-api-cpp-client.

Got it. I may do a roll up of little fixes that we have made internally and
push them out. I'll look at the date class along with that.

On Wed, Jan 7, 2015 at 1:41 PM, rcmaniac25 [email protected] wrote:

Ok, I ended up merging @snnn https://github.com/snnn's changes for the
underscore changes. I also saw that he did (smarter then my own) "typedef
DateTime Date;" while I had originally implemented a Date class and
essentially copied the content from DateTime to it.

—
Reply to this email directly or view it on GitHub
#2 (comment)
.

from google-api-cpp-client.

I merged in the pull request. That was to the v0.1 branch.
master, however, is the new default branch, where I have done a similar update.

from google-api-cpp-client.