Comments (4)
@clem1 Any thoughts here. I don't see a strong reason for this to be its own goroutine, but maybe you had given this some thought?
from gonids.
So this code was copied from the official Golang text lexer [0]. I guess the main reason is to not wait for the end of the lexing in the parsing, e.g. parser can exit earlier without having the lexing to be completely finished. Not sure it maters in our case since rules are relatively small and very fast to lex.
Happy to have the lex() being fully sequential.
[0] https://talks.golang.org/2011/lex.slide#1
from gonids.
@julienschmidt do you want to take a look at making this change? I don't know that it gains us a lot to remove it, so I don't plan to tackle this in the short term (versus adding features, better parsing, etc.)
If not I'll close this issue for now.
from gonids.
I'm actually curious if this would pay off. I'll write a PoC and benchmark as soon as I have time for it.
from gonids.
Related Issues (20)
- Handling escaped characters in content
- Errors parsing network info HOT 1
- PR for additional validations HOT 3
- Nested network info parsing unsupported HOT 4
- Missing protocols and transformations HOT 10
- cifuzz broken HOT 2
- GolangCI dead HOT 3
- fix lint errors HOT 1
- Open ended port ranges not correctly handled HOT 2
- Add support for `target` keyword HOT 1
- Can't parse Snort rule with error: rpc error: code = Unknown desc = invalid special characters escaping HOT 1
- OSS-Fuzz issue 49328 HOT 1
- OSS-Fuzz issue 49653 HOT 1
- have a question about base64_decode HOT 3
- OSS-Fuzz issue 54669 HOT 1
- OSS-Fuzz issue 54867
- OSS-Fuzz issue 55416 HOT 1
- OSS-Fuzz issue 55592 HOT 1
- OSS-Fuzz issue 56718 HOT 1
- OSS-Fuzz issue 58318 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gonids.