Git Product home page Git Product logo

Comments (10)

spearce avatar spearce commented on May 8, 2024
Similar to how Gerrit formats a file side by side, allow viewing a modified text file
in a side by side view.

Gerrit's method of rendering this in a 4 column table with each line being a new row
is horrid and should be replicated. Critique and GitHub get this more right by rendering
4 divs in a 1 row table, enabling the user to select a contiguous section of source
code from either side.

Reported by None on 2012-11-11 15:17:41

from gitiles.

spearce avatar spearce commented on May 8, 2024
I don't really want to reinvent the wheel here. IMHO we should reuse the side by side
diff logic from Gerrit, but of course that's currently impossible because Gerrit uses
GWT, and does various other things wrong. So, first let's fix Gerrit.

Reported by None on 2012-11-11 15:19:39

from gitiles.

spearce avatar spearce commented on May 8, 2024
Gerrit is looking at moving to Codemirror for side-by-side diffs. We should do that
too: not too much fancy JS, hopefully largely pasting it in, I haven't looked. Even
if not, we should be able to reuse more code because it's just the server-side stuff
(serving diff info), no more GWT.

Reported by None on 2013-06-18 17:26:58

from gitiles.

spearce avatar spearce commented on May 8, 2024
For reference, I requested this via email as something that I think is important for
parity between ViewVC and gitiles if Chromium is moving from the former to the latter.

Reported by None on 2014-05-05 09:26:08

from gitiles.

spearce avatar spearce commented on May 8, 2024
Can/should it be optional? I personally prefer the single format.

Reported by None on 2014-05-06 15:58:15

from gitiles.

spearce avatar spearce commented on May 8, 2024

Reported by None on 2014-08-25 17:06:53

from gitiles.

spearce avatar spearce commented on May 8, 2024
Any update on the prospects for this?

Reported by None on 2014-08-25 17:08:20

from gitiles.

spearce avatar spearce commented on May 8, 2024
Issue chromium:384604 has been merged into this issue.

Reported by None on 2014-08-25 17:16:06

from gitiles.

spearce avatar spearce commented on May 8, 2024
Nope. :(

IIRC we tried using CodeMirror3 and it was too slow/awkward to use for Chromium project.
So a new side by side view needs to be built from scratch in Gitiles, but that work
hasn't been estimated or scheduled.

Reported by None on 2014-08-25 17:21:13

from gitiles.

spearce avatar spearce commented on May 8, 2024
Comment deleted

Reported by None on 2015-07-12 05:38:16

from gitiles.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.