Comments (10)
Similar to how Gerrit formats a file side by side, allow viewing a modified text file
in a side by side view.
Gerrit's method of rendering this in a 4 column table with each line being a new row
is horrid and should be replicated. Critique and GitHub get this more right by rendering
4 divs in a 1 row table, enabling the user to select a contiguous section of source
code from either side.
Reported by None
on 2012-11-11 15:17:41
from gitiles.
I don't really want to reinvent the wheel here. IMHO we should reuse the side by side
diff logic from Gerrit, but of course that's currently impossible because Gerrit uses
GWT, and does various other things wrong. So, first let's fix Gerrit.
Reported by None
on 2012-11-11 15:19:39
from gitiles.
Gerrit is looking at moving to Codemirror for side-by-side diffs. We should do that
too: not too much fancy JS, hopefully largely pasting it in, I haven't looked. Even
if not, we should be able to reuse more code because it's just the server-side stuff
(serving diff info), no more GWT.
Reported by None
on 2013-06-18 17:26:58
from gitiles.
For reference, I requested this via email as something that I think is important for
parity between ViewVC and gitiles if Chromium is moving from the former to the latter.
Reported by None
on 2014-05-05 09:26:08
from gitiles.
Can/should it be optional? I personally prefer the single format.
Reported by None
on 2014-05-06 15:58:15
from gitiles.
Reported by None
on 2014-08-25 17:06:53
from gitiles.
Any update on the prospects for this?
Reported by None
on 2014-08-25 17:08:20
from gitiles.
Issue chromium:384604 has been merged into this issue.
Reported by None
on 2014-08-25 17:16:06
from gitiles.
Nope. :(
IIRC we tried using CodeMirror3 and it was too slow/awkward to use for Chromium project.
So a new side by side view needs to be built from scratch in Gitiles, but that work
hasn't been estimated or scheduled.
Reported by None
on 2014-08-25 17:21:13
from gitiles.
Comment deleted
Reported by None
on 2015-07-12 05:38:16
from gitiles.
Related Issues (20)
- markdown TOC renderer should also include at least H4-level items
- Symlink viewer renders broken link to destination
- Build impossible on Mac M1 / arm. Please upgrade bazel version HOT 1
- Gerrit cannot be returned properly after browsing code through the Gitiles plugin in Gerrit HOT 1
- Building with bazel fails with `reason: '<>' with anonymous inner classes is not supported in -source 8`
- C++14 single quote (') digit separators aren't rendered correctly in header files
- #./tools/maven/mvn.sh deploy
- https://android.googlesource.com/ the json format error HOT 3
- Add 'y' shortcut to generate permalink to commit HOT 1
- Render graph using mermaid.js in .md files HOT 1
- Unc0ver-volvo
- https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#ni HOT 1
- ok
- Ciris
- gitlies
- git clone https://gerrit.googlesource.com/gitiles HOT 1
- We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA ([login here](https://cla.developers.google.com/) to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
- Menuka Vishal
- Código de seguridad de WhatsApp de system company in master data (+52 221 199 1681)
- `text and `json` formats for a tag does not work correctly.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gitiles.